Fix at-rule-no-deprecated false positives for @apply (#8630)

Mouvedia · web-flow · commit 0a5f75bc6ff3 · 2025-07-08T22:02:15.000+02:00
diff --git a/.changeset/pink-spoons-invent.md b/.changeset/pink-spoons-invent.md
@@ -0,0 +1,5 @@
+---
+"stylelint": patch
+---
+
+Fixed: `at-rule-no-deprecated` false positives for `@apply`
diff --git a/lib/reference/atKeywords.cjs b/lib/reference/atKeywords.cjs
diff --git a/lib/reference/atKeywords.mjs b/lib/reference/atKeywords.mjs
@@ -1,13 +1,14 @@
 import uniteSets from '../utils/uniteSets.mjs';
 
 /** @type {ReadonlySet<string>} */
-export const deprecatedAtKeywords = new Set(['apply', 'document', 'nest', 'viewport']);
+export const deprecatedAtKeywords = new Set(['document', 'nest', 'viewport']);
 
 /**
  * @see https://www.w3.org/TR/css-nesting-1/#conditionals
  * @type {ReadonlySet<string>}
  */
 export const nestingSupportedAtKeywords = new Set([
+	'apply',
 	'container',
 	'layer',
 	'media',
diff --git a/lib/rules/at-rule-descriptor-no-unknown/__tests__/index.mjs b/lib/rules/at-rule-descriptor-no-unknown/__tests__/index.mjs
@@ -1,4 +1,6 @@
 import rule from '../index.mjs';
+import { stripIndent } from 'common-tags';
+
 const { messages, ruleName } = rule;
 
 testRule({
@@ -153,5 +155,53 @@ testRule({
 				},
 			],
 		},
+		{
+			code: stripIndent`
+				@mixin --qux-baz(@contents) {
+					@supports (overflow-anchor: auto) {
+						@contents;
+					}
+				}
+
+				body {
+					@apply --qux-baz {
+						@font-face {
+						  foo: normal;
+						}
+					}
+				}
+			`,
+			message: messages.rejected('@font-face', 'foo'),
+			line: 10,
+			column: 5,
+			endLine: 10,
+			endColumn: 8,
+			description: 'without indirection',
+		},
+		{
+			code: stripIndent`
+				@mixin --qux-baz(@contents) {
+					@supports (overflow-anchor: auto) {
+						@font-face {
+							@contents;
+						}
+					}
+				}
+
+				body {
+					@apply --qux-baz {
+						foo: normal;
+					}
+				}
+			`,
+			message: messages.rejected('@font-face', 'foo'),
+			line: 11,
+			column: 3,
+			endLine: 11,
+			endColumn: 6,
+			description: 'with indirection',
+			// TODO: unskip once we support @mixin indirection
+			skip: true,
+		},
 	],
 });
diff --git a/lib/rules/at-rule-descriptor-value-no-unknown/__tests__/index.mjs b/lib/rules/at-rule-descriptor-value-no-unknown/__tests__/index.mjs
@@ -1,4 +1,6 @@
 import rule from '../index.mjs';
+import { stripIndent } from 'common-tags';
+
 const { messages, ruleName } = rule;
 
 testRule({
@@ -89,5 +91,53 @@ testRule({
 			endColumn: 55,
 			description: 'an unknown value in a nested at-rule',
 		},
+		{
+			code: stripIndent`
+				@mixin --qux-baz(@contents) {
+					@supports (overflow-anchor: auto) {
+						@contents;
+					}
+				}
+
+				body {
+					@apply --qux-baz {
+						@font-face {
+						  ascent-override: foo;
+						}
+					}
+				}
+			`,
+			message: messages.rejected('ascent-override', 'foo'),
+			line: 10,
+			column: 22,
+			endLine: 10,
+			endColumn: 25,
+			description: 'without indirection',
+		},
+		{
+			code: stripIndent`
+				@mixin --qux-baz(@contents) {
+					@supports (overflow-anchor: auto) {
+						@font-face {
+							@contents;
+						}
+					}
+				}
+
+				body {
+					@apply --qux-baz {
+						ascent-override: foo;
+					}
+				}
+			`,
+			message: messages.rejected('ascent-override', 'foo'),
+			line: 11,
+			column: 20,
+			endLine: 11,
+			endColumn: 23,
+			description: 'with indirection',
+			// TODO: unskip once we support @mixin indirection
+			skip: true,
+		},
 	],
 });
diff --git a/lib/rules/at-rule-no-deprecated/__tests__/index.mjs b/lib/rules/at-rule-no-deprecated/__tests__/index.mjs
@@ -20,6 +20,9 @@ testRule({
 		{
 			code: '@CONTAINER (min-width: 500px) {}',
 		},
+		{
+			code: 'a { @apply --foo; }',
+		},
 	],
 
 	reject: [
@@ -67,15 +70,6 @@ testRule({
 				text: '',
 			},
 		},
-		{
-			code: 'a { @apply foo; }',
-			unfixable: true,
-			message: messages.rejected('@apply'),
-			line: 1,
-			column: 5,
-			endLine: 1,
-			endColumn: 11,
-		},
 		{
 			code: 'a { @nest .foo {} @nest .bar {} }',
 			fixed: 'a { .foo {} .bar {} }',
@@ -120,12 +114,12 @@ testRule({
 
 	reject: [
 		{
-			code: 'a { @apply foo; }',
-			message: messages.rejected('@apply'),
+			code: 'a { @nest .foo & {} }',
+			message: messages.rejected('@nest'),
 			line: 1,
 			column: 5,
 			endLine: 1,
-			endColumn: 11,
+			endColumn: 10,
 		},
 	],
 });

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"stylelint": patch
 +---
++
 +Fixed: `at-rule-no-deprecated` false positives for `@apply`