adding on started listener to display nestRemoting method in swagger …#208
adding on started listener to display nestRemoting method in swagger …#208flvndvd wants to merge 2 commits intostrongloop:masterfrom
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Hello, thank you for the pull request.
I am afraid the event started is not the right one to use for detecting new endpoints added by nestRemoting. Consider what happens when the app calls nestRemoting well after it has started?
A better solution is to modify LoopBack to emit a new event whenever a new shared method is defined, e.g. remoteMethodAdded. Check here and here how remoteMethodDisabled is implemented - this new event can be added in a similar fashion.
Last but not least, I'll need you to add a unit-test to verify your implementation, see the test(s) for remoteMethodDisabled event for inspiration.
|
@slnode ok to test |
|
@bajtos |
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Thank you for the update. strongloop/loopback#3322 has been merged and released, let's get this part finished too.
Now I need you to add a test to verify this new feature, see my earlier comment:
Last but not least, I'll need you to add a unit-test to verify your implementation, see the test(s) for
remoteMethodDisabledevent for inspiration.
|
Closing as abandoned. |
|
@DAVIDFlavien I am puzzled by your "thumbs down" on my #208 (comment). If you are still keen to get this finished, then please address my comments above and either reopen this pull request or send a new one. |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Close as I'm reworking on the PR at #222 |
4 participants
Description
Add nestRemoting routes in the explorer
Related issues
Checklist
guide