Skip to content

Add new event "remoteMethodAdded"#3322

Merged
bajtos merged 1 commit intostrongloop:masterfrom
flvndvd:fix/nestRemotingRoutes
Mar 31, 2017
Merged

Add new event "remoteMethodAdded"#3322
bajtos merged 1 commit intostrongloop:masterfrom
flvndvd:fix/nestRemotingRoutes

Conversation

@flvndvd
Copy link

@flvndvd flvndvd commented Mar 29, 2017

Description

Add new event remoteMethodAdded triggered when nestRemoting is called

Related issues

#2409
strongloop/loopback-component-explorer#167

  • None

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@slnode
Copy link

slnode commented Mar 29, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Mar 29, 2017

Can one of the admins verify this patch?

3 similar comments
@slnode
Copy link

slnode commented Mar 29, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Mar 29, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Mar 29, 2017

Can one of the admins verify this patch?

@bajtos
Copy link
Member

bajtos commented Mar 30, 2017

@slnode ok to test

@bajtos bajtos changed the title Fix/nest remoting routes Add new event "remoteMethodAdded" Mar 30, 2017
@bajtos bajtos added the feature label Mar 30, 2017
@bajtos bajtos requested review from kjdelisle and superkhau March 30, 2017 11:35
@bajtos
Copy link
Member

bajtos commented Mar 30, 2017

Thank you @DAVIDFlavien for the pull request. The changes looks mostly good to be. For completeness, could you please emit the new event from Model.remoteMethod too?

@bajtos bajtos self-requested a review March 30, 2017 11:36
@bajtos bajtos self-assigned this Mar 30, 2017
@flvndvd
Copy link
Author

flvndvd commented Mar 30, 2017

Done in 8745f4e

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Emit a new method "remoteMethodAdded" whenever a new method is added,
typically when `Model.remoteMethod` or `Model.nestRemoting` is called.

The method is emitted both by the Model affected and the application
object.
@bajtos bajtos force-pushed the fix/nestRemotingRoutes branch from 8745f4e to 981bd30 Compare March 31, 2017 13:33
@bajtos
Copy link
Member

bajtos commented Mar 31, 2017

@DAVIDFlavien thank you for the update. The patch LGTM now.

To speed up the process, I have squash all commits into a single one with a descriptive commit message following our 50/72 rule and git push -f into your feature branch.

This pull request can be landed once the CI builds are done.

@bajtos bajtos merged commit 75fdd3c into strongloop:master Mar 31, 2017
@bajtos
Copy link
Member

bajtos commented Mar 31, 2017

Landed, thank you for the contribution! 🎉

@sebastianfelipe
Copy link

sebastianfelipe commented May 6, 2017

Is this gonna be in a new subversion soon? Need it please! Thanks 👍

@bajtos
Copy link
Member

bajtos commented May 22, 2017

@sebastianfelipe I believe the feature was released in loopback@3.6.0.

@sebastianfelipe
Copy link

Thanks @bajtos, is there something for 2.X.X? I'm not using the latest version yet. I'd really appreciate it.

@bajtos
Copy link
Member

bajtos commented May 25, 2017

@sebastianfelipe 2.x is in LTS mode, we are no longer adding new features there. See https://loopback.io/doc/en/contrib/Long-term-support.html.

@sebastianfelipe
Copy link

I updated to this new release. I'm using the 3.9.0 version, but the nested models are not appearing in the explorer menu :/. It were created and I can visualize them using the Model.sharedClass._methods, but there doesn't appear in the explorer :/

@sebastianfelipe
Copy link

Adding to the previous situation, in the Model.sharedClass._methods, doesn't appear the direct prototype. methods to list them all at once (if there is a possibility to do it)

@bajtos
Copy link
Member

bajtos commented Aug 23, 2017

@sebastianfelipe Please open a new issue and provide us with a small app reproducing your problem, see http://loopback.io/doc/en/contrib/Reporting-issues.html#bug-report. Please mention my github handle @bajtos in the issue description, so that I receive a notification and can take a look.

@strongloop strongloop locked and limited conversation to collaborators Aug 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants