Repository navigation
Add n/p shortcuts (same behavior as in Google Reader) - #80
Closed
jefffederman wants to merge 2 commits into
Closed
jefffederman wants to merge 2 commits into
jefffederman wants to merge 2 commits into
Conversation
…dated locale files and shortcuts partial accordingly.
Collaborator
|
I can get behind these changes - I am in the middle of moving the clientside JS to backbone (https://github.com/swanson/stringer/tree/backbone) because it is getting too hairy - so it may be a bit before I get this merged in. |
Collaborator
|
n/p implemented in 0947e3b |
Collaborator
|
Thanks for this - sorry it was a bit of a hack job to get it actually merged. I really like the idea of only scrolling the view if it is off screen, it works really well now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt,
Very nice work on Stringer, am thinking it could be my Google Reader replacement. Thought I'd add n/p shortcuts to complement the j/k shortcuts. I use them all the time in Reader and missed having them in Stringer.
As to what I changed:
• added Mousetrap bindings for the n/p shortcuts
• added an 'updateScroll' callback so that scroll only updates for n/p movements once article is above/beneath the viewport
• added https://github.com/teamdf/jquery-visible to help with the viewport code
• updated the locale files to include the n/p description (used Google Translate)
• updated the shortcuts partial to include the n/p description
• updated the layout to include the jquery-visible script
Specs are passing, though I didn't create any integration specs (or JS specs) for this branch. Browser tested in Chrome, Safari and IE8.
Best,
Jeff