Skip to content

Mark all items read when the fever group_id is 0 - #256

Merged
swanson merged 1 commit into
stringer-rss:masterfrom
jmazzi:bugfix/fever_group_0
Aug 12, 2013
Merged

swanson merged 1 commit into
stringer-rss:masterfrom
jmazzi:bugfix/fever_group_0

Conversation

@jmazzi

@jmazzi jmazzi commented Aug 6, 2013

Copy link
Copy Markdown
Contributor

Stringer is not currently marking all items as read when the group_id is 0. The Fever API docs state:

You can mark the “Kindling” super group (and the “Sparks” super group) as read by adding the following four arguments to your POST data:

mark=group
as=read
id=0
before=? where ? is replaced with the Unix timestamp of the the local client’s last items API request

Stringer has no notion of kindling, in this case it's safe to mark all items read.

@swanson

swanson commented Aug 12, 2013

Copy link
Copy Markdown
Collaborator

Good find @jmazzi - would you mind extracting out the literal 0 into some constant like "KINDLING_SUPER_GROUP", I'm worried I will forget why we made this change in a few weeks :)

Other than that, looks good to be merged.

@jmazzi

jmazzi commented Aug 12, 2013

Copy link
Copy Markdown
Contributor Author

@swanson done

swanson pushed a commit that referenced this pull request Aug 12, 2013
Mark all items read when the fever group_id is 0
@swanson
swanson merged commit ff61c4c into stringer-rss:master Aug 12, 2013
@swanson

swanson commented Aug 12, 2013

Copy link
Copy Markdown
Collaborator

Thank you, sir!

@jmazzi

jmazzi commented Aug 12, 2013

Copy link
Copy Markdown
Contributor Author

No problem!

Thanks for creating a great project I use daily :-D
On Aug 12, 2013 5:42 PM, "matt swanson" notifications@github.com wrote:

Thank you, sir!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/256#issuecomment-22528119
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants