Repository navigation
Mark all items read when the fever group_id is 0 - #256
Merged
Merged
Conversation
Collaborator
|
Good find @jmazzi - would you mind extracting out the literal 0 into some constant like "KINDLING_SUPER_GROUP", I'm worried I will forget why we made this change in a few weeks :) Other than that, looks good to be merged. |
Contributor
Author
|
@swanson done |
swanson
pushed a commit
that referenced
this pull request
Aug 12, 2013
Mark all items read when the fever group_id is 0
Collaborator
|
Thank you, sir! |
Contributor
Author
|
No problem! Thanks for creating a great project I use daily :-D
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stringer is not currently marking all items as read when the
group_idis 0. The Fever API docs state:Stringer has no notion of kindling, in this case it's safe to mark all items read.