Repository navigation
A simple and quick way to have feed groups in fever clients. - #244
Conversation
|
👍 Exactly what I had in mind too. :) |
|
@gaynetdinov is your branch production-ready? I'd like to try it out. |
There was a problem hiding this comment.
Maybe spell and with capital letters to emphasize its use as an SQL keyword?
|
@swanson any opinion on this feature? I think it's a good piece of functionality. |
|
@Koronen looks fine to me - only thing I noticed was that we could probably use better test coverage on the changes to |
|
Is there still demand for this feature? I'd like to either merge or close this PR. /cc @gaynetdinov @jeroenj @jalcine @swanson |
|
Yes, this is still one of the biggest features I am still missing in Stringer. I'd like to have groups in the web interface too (as long as I don't have a Mac app that syncs with it). |
|
Sound good. Please remember to also look into the test coverage for |
There was a problem hiding this comment.
I'm not sure about these constants. Are they needed?
There was a problem hiding this comment.
See the Fever API docs, headings "Groups" and "Write". It turns out these constants are wrong, KINDLING_GROUP_ID should be 0 and SPARKS_GROUP_ID should be -1. Feel free to correct this.
As to your question if these constants are needed, I'd say that yes they are. Even though we don't have a notion of sparks for feeds, we should still handle requests using these IDs. My suggestion for handling these requests is to simply mark all feeds as read (which was the previous behavior).
There was a problem hiding this comment.
Ok, so I changed constants and left the same behaviour for requests with such group_id.
|
Sorry for another delay guys (turns out parenting is hard and time consumption thing 👶 😄 ). I made requested changes, added test for Thank you for your patient. |
|
I'll try it out one of these days. Congrats with the baby! 😃 |
|
Works flawlessly! 👍 Groups in the web interface would be nice, but this already provides what I need. |
There was a problem hiding this comment.
I don't think that the order clause should be part of this scope, since it's not related to filtering feeds that have a group. That clause should be moved somewhere else, such as app/fever_api/read_feeds_groups.rb:20.
|
I think the code we have now looks good. Nicely done @gaynetdinov! I've got one more question though. Should we add a data migration of some sort (for all currently running production instances of Stringer) to put all currently ungrouped feeds into a new group called "Ungrouped"? I don't think we need to for the web UI (currently), but I think it would ease future work dealing with feed groups. |
|
I'd say that an "Ungrouped" group defeats the purpose of |
|
Good point! The we should probably modify |
|
After running this code for about a month now I've just noticed the first issue with it: if you go into the unread group and mark all as read in there it doesn't seem to be updated in stringer. The items are still marked as unread in stringer and they appear back in Reeder as soon as you refresh. |
|
@gaynetdinov do you think you can find the time to avoid creating the "Ungrouped" group? @jeroenj have you attempted any debugging of your issue? Could it be related to the creation of an "Ungrouped" group? |
|
I did not yet try to debug the issue, but I'll try to get to it somewhere this week. |
There are some feature requests about adding groups for feeds. Currently I'm trying to implement such feature, but I find this a bit complicated due to design, usability and other front-end issues. However, adding groups to fever API is simple and straightforward, so I thought that having groups at least in the clients would be great.
These changes do not affect UI at any way. Also I modified
opml_parser.rbandimport_from_opml.rbto consider groups so you can re-import the samesubscriptions.xmljust to attach existing feeds to groups.Tested on Reeder for iPhone.