Skip to content

A simple and quick way to have feed groups in fever clients. - #244

Merged
Koronen merged 1 commit into
stringer-rss:masterfrom
gaynetdinov:groups-for-feeds-in-fever-api
May 27, 2014
Merged

Koronen merged 1 commit into
stringer-rss:masterfrom
gaynetdinov:groups-for-feeds-in-fever-api

Conversation

@gaynetdinov

Copy link
Copy Markdown

There are some feature requests about adding groups for feeds. Currently I'm trying to implement such feature, but I find this a bit complicated due to design, usability and other front-end issues. However, adding groups to fever API is simple and straightforward, so I thought that having groups at least in the clients would be great.

These changes do not affect UI at any way. Also I modified opml_parser.rb and import_from_opml.rb to consider groups so you can re-import the same subscriptions.xml just to attach existing feeds to groups.

Tested on Reeder for iPhone.

@jeroenj

jeroenj commented Jul 26, 2013

Copy link
Copy Markdown
Contributor

👍 Exactly what I had in mind too. :)

@jalcine

jalcine commented Aug 25, 2013

Copy link
Copy Markdown

@gaynetdinov is your branch production-ready? I'd like to try it out.

Comment thread app/repositories/story_repository.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe spell and with capital letters to emphasize its use as an SQL keyword?

@Koronen

Koronen commented Nov 17, 2013

Copy link
Copy Markdown
Contributor

@swanson any opinion on this feature? I think it's a good piece of functionality.

@swanson

swanson commented Nov 17, 2013

Copy link
Copy Markdown
Collaborator

@Koronen looks fine to me - only thing I noticed was that we could probably use better test coverage on the changes to import_from_opml

@Koronen

Koronen commented Feb 24, 2014

Copy link
Copy Markdown
Contributor

Is there still demand for this feature? I'd like to either merge or close this PR. /cc @gaynetdinov @jeroenj @jalcine @swanson

@jeroenj

jeroenj commented Feb 24, 2014

Copy link
Copy Markdown
Contributor

Yes, this is still one of the biggest features I am still missing in Stringer. I'd like to have groups in the web interface too (as long as I don't have a Mac app that syncs with it).

@gaynetdinov

Copy link
Copy Markdown
Author

Sorry for such long delay guys. I can implement requested changes from @Koronen, then rebase this branch to squash commits into one and after that @Koronen or @swanson could merge this pull-request. Does that make sense?

@Koronen

Koronen commented Feb 25, 2014

Copy link
Copy Markdown
Contributor

Sound good. Please remember to also look into the test coverage for import_from_opml as pointed out by @swanson.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about these constants. Are they needed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the Fever API docs, headings "Groups" and "Write". It turns out these constants are wrong, KINDLING_GROUP_ID should be 0 and SPARKS_GROUP_ID should be -1. Feel free to correct this.

As to your question if these constants are needed, I'd say that yes they are. Even though we don't have a notion of sparks for feeds, we should still handle requests using these IDs. My suggestion for handling these requests is to simply mark all feeds as read (which was the previous behavior).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I changed constants and left the same behaviour for requests with such group_id.

@gaynetdinov

Copy link
Copy Markdown
Author

Sorry for another delay guys (turns out parenting is hard and time consumption thing 👶 😄 ).

I made requested changes, added test for import_from_opml and squashed all commits into one.
I tested it against old reeder version 3.2 locally and everything worked well for me. However it would be great if someone else also will test this branch.

Thank you for your patient.

@jeroenj

jeroenj commented Apr 15, 2014

Copy link
Copy Markdown
Contributor

I'll try it out one of these days.

Congrats with the baby! 😃

@jeroenj

jeroenj commented Apr 15, 2014

Copy link
Copy Markdown
Contributor

Works flawlessly! 👍

Groups in the web interface would be nice, but this already provides what I need.

Comment thread app/repositories/feed_repository.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the order clause should be part of this scope, since it's not related to filtering feeds that have a group. That clause should be moved somewhere else, such as app/fever_api/read_feeds_groups.rb:20.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Koronen

Koronen commented Apr 17, 2014

Copy link
Copy Markdown
Contributor

I think the code we have now looks good. Nicely done @gaynetdinov! I've got one more question though. Should we add a data migration of some sort (for all currently running production instances of Stringer) to put all currently ungrouped feeds into a new group called "Ungrouped"? I don't think we need to for the web UI (currently), but I think it would ease future work dealing with feed groups.

@jeroenj

jeroenj commented Apr 17, 2014

Copy link
Copy Markdown
Contributor

I'd say that an "Ungrouped" group defeats the purpose of group_id being nil. I would rather solve this on UI level than putting all of them into an Ungrouped group.

@Koronen

Koronen commented Apr 17, 2014

Copy link
Copy Markdown
Contributor

Good point! The we should probably modify ImportFromOpml to not create the group "Ungrouped".

@jeroenj

jeroenj commented May 10, 2014

Copy link
Copy Markdown
Contributor

After running this code for about a month now I've just noticed the first issue with it: if you go into the unread group and mark all as read in there it doesn't seem to be updated in stringer. The items are still marked as unread in stringer and they appear back in Reeder as soon as you refresh.

@Koronen

Koronen commented May 18, 2014

Copy link
Copy Markdown
Contributor

@gaynetdinov do you think you can find the time to avoid creating the "Ungrouped" group?

@jeroenj have you attempted any debugging of your issue? Could it be related to the creation of an "Ungrouped" group?

@jeroenj

jeroenj commented May 19, 2014

Copy link
Copy Markdown
Contributor

I did not yet try to debug the issue, but I'll try to get to it somewhere this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants