Skip to content

Don't fail if feed has not changed - #231

Merged
swanson merged 3 commits into
stringer-rss:masterfrom
jeroenj:last-modified
Jul 17, 2013
Merged

swanson merged 3 commits into
stringer-rss:masterfrom
jeroenj:last-modified

Conversation

@jeroenj

@jeroenj jeroenj commented Jul 17, 2013

Copy link
Copy Markdown
Contributor

#fetch_and_parse returns 304 (integer) when the If-Modified-Since is older than @feed.last_fetched.

I had quite a few feeds displaying errors because of this.

@badboy

badboy commented Jul 17, 2013

Copy link
Copy Markdown

This would explain why so much of my feeds are currently in a failed state (#229)

@jeroenj

jeroenj commented Jul 17, 2013

Copy link
Copy Markdown
Contributor Author

Yep. My logs wre filled with undefined methodlast_modified' for 304:Fixnum`.

@swanson

swanson commented Jul 17, 2013

Copy link
Copy Markdown
Collaborator

My bad on this - looks like I didn't do enough due-dillengce on #224

swanson pushed a commit that referenced this pull request Jul 17, 2013
Don't fail if feed has not changed
@swanson
swanson merged commit e00bb5d into stringer-rss:master Jul 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants