Skip to content

Allow viewing stories by feed - #213

Merged
swanson merged 5 commits into
stringer-rss:masterfrom
ajalexander:view_feeds
Sep 22, 2013
Merged

swanson merged 5 commits into
stringer-rss:masterfrom
ajalexander:view_feeds

Conversation

@ajalexander

Copy link
Copy Markdown
Contributor

This patch adds the ability to view stories by feed (#124).

The feeds page was changed to link to a feed-specific view of stories and to show the number of unread stories for each feed. While a full category solution (#46) would be a nice addition to a feed-specific view, this partially alleviates the need for it for my personal workflow.

I don't love the URL (/feed/feed_id) used for the feed-specific view, but couldn't come up with anything better either.

The existing "mark all as read" functionality still works when run from the feed-specific page. By that I mean that if you are viewing a feed, marking all stories as read only affects the viewed feed.

Feeds Page:
feed_list

Feed View:
feed_view

@christianschmidt

Copy link
Copy Markdown
Contributor

+1 for that as a first step to category/folder view.

@aleks

aleks commented Jul 10, 2013

Copy link
Copy Markdown

+1

@Koronen

Koronen commented Sep 5, 2013

Copy link
Copy Markdown
Contributor

I think this is a reasonable feature, also the code looks good, seems to work and the current tests pass. However, I don't see any tests added to cover this new functionality. @ajalexander, maybe you could look into adding some?

@swanson

swanson commented Sep 5, 2013

Copy link
Copy Markdown
Collaborator

My hesitation to merge this was that I would be committing to this path for the future Groups/Folders/Tags features (of which I still have not gotten around to). But in hindsight that is kind of silly, since we can always re-work this if it doesn't fit in the end (and since I have not found the motivation/time/inspiration to tackle groups yet this is all speculative).

Thanks for bumping this @Koronen - I agree, let's get some tests on this and then it should be good to merge!

@ajalexander

Copy link
Copy Markdown
Contributor Author

@Koronen, @swanson: I can look into adding tests sometime next week.

@swanson, At this point, the pull request is two months old. Should I merge in the changes since then or would you rather do that as part of accepting the pull request? Alternatively, I could redo the changes in a new branch based off of the current master and create a new pull request.

@swanson

swanson commented Sep 6, 2013

Copy link
Copy Markdown
Collaborator

@ajalexander I don't think it should be too painful to merge, I can take care of it.

@ajalexander

Copy link
Copy Markdown
Contributor Author

@swanson , do the provided tests suffice or were you looking for something more expansive?

swanson pushed a commit that referenced this pull request Sep 22, 2013
Allow viewing stories by feed
@swanson
swanson merged commit a7d10b7 into stringer-rss:master Sep 22, 2013
@skyschub

Copy link
Copy Markdown

😍

thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants