Repository navigation
Allow viewing stories by feed - #213
Conversation
|
+1 for that as a first step to category/folder view. |
|
+1 |
|
I think this is a reasonable feature, also the code looks good, seems to work and the current tests pass. However, I don't see any tests added to cover this new functionality. @ajalexander, maybe you could look into adding some? |
|
My hesitation to merge this was that I would be committing to this path for the future Groups/Folders/Tags features (of which I still have not gotten around to). But in hindsight that is kind of silly, since we can always re-work this if it doesn't fit in the end (and since I have not found the motivation/time/inspiration to tackle groups yet this is all speculative). Thanks for bumping this @Koronen - I agree, let's get some tests on this and then it should be good to merge! |
|
@Koronen, @swanson: I can look into adding tests sometime next week. @swanson, At this point, the pull request is two months old. Should I merge in the changes since then or would you rather do that as part of accepting the pull request? Alternatively, I could redo the changes in a new branch based off of the current master and create a new pull request. |
|
@ajalexander I don't think it should be too painful to merge, I can take care of it. |
|
@swanson , do the provided tests suffice or were you looking for something more expansive? |
Allow viewing stories by feed
|
😍 thank you very much! |
This patch adds the ability to view stories by feed (#124).
The feeds page was changed to link to a feed-specific view of stories and to show the number of unread stories for each feed. While a full category solution (#46) would be a nice addition to a feed-specific view, this partially alleviates the need for it for my personal workflow.
I don't love the URL (/feed/feed_id) used for the feed-specific view, but couldn't come up with anything better either.
The existing "mark all as read" functionality still works when run from the feed-specific page. By that I mean that if you are viewing a feed, marking all stories as read only affects the viewed feed.
Feeds Page:

Feed View:
