Repository navigation
update circleci to build image and push to dockerhub, pending approval - #1065
Conversation
d6306c5 to
9fe1f2f
Compare
9fe1f2f to
d83842b
Compare
|
@mockdeep action item requests for you:
|
mockdeep
left a comment
There was a problem hiding this comment.
Thanks so much for this @guidopetri! I've added some suggestions. I added the env variables on CircleCI, but the build still didn't work. I think that's because CircleCI doesn't pass env variables to forked builds for security, so I think that probably makes my suggestion to build only on main a better way.
How confident are you that it'll work? :D We can try merging to As for the commit I just added, I thought it'd be more convenient for you to review a separate commit, but we can squash everything later. |
4845f47 to
e4fa1ac
Compare
|
Looks great! Thanks so much for this!
Well, I'm more confident that we can revert if it doesn't work out, so worth a try! |
Confidence that this will work: 0% :)
I renamed the previous
buildjob torun_tests, since it seemed more apt, if we're adding a "build the docker image" step. I think this requires a change on the github repo / PR config, though, so I'm fine reverting that change.This PR hopefully adds the
build-and-publish-imageworkflow, which waits for tests to run + waits for an approval from a maintainer / someone with merge access to the repo to run it. I think we need to create thestringer-rssDockerhub user/organization, and we must useDOCKER_LOGINandDOCKER_PASSWORDenv vars but I'm not sure where to place them in the CI file in a safe way. (is this something we set up in CircleCI itself as a secret?)