Skip to content

JS/CSS compression #134

Closed
Closed

Description

@swanson

asset-pack seems to be causing more problems than it is worth. I've received 4 reports already from people that are having trouble getting the app to work because of Javascript Runtimes.

Ultimately I think there are too many moving parts - maybe we can just concatenate the JS/CSS files and not worry about compression.
#112 #117 #45

Activity

  1. petersonfs commented on May 16, 2013

    @petersonfs
    Contributor

    If the problem exist we can reproduce and fix, what do you think?

  2. swanson commented on May 16, 2013

    @swanson
    CollaboratorAuthor

    Well the big problem is that people on Ubuntu seem to have to install Node.js - which seems silly just to save a few bytes compressing the javascript. One thing to try is to switch to JSMin - even though it has big warnings to not use it, I don't think it needs a JS runtime to work.

  3. petersonfs commented on May 16, 2013

    @petersonfs
    Contributor

    Maybe we can change the compressor? I use the uglify because i never had problem with that. But the assetpack provide another choices like:

    • jsmin
    • yui (yahoo)
    • closure (google)

    Let's try to use another?

  4. swanson commented on May 16, 2013

    @swanson
    CollaboratorAuthor

    Closure -> I think this calls a web API, not ideal.

    YUI -> needs Java installed

    I'd say let's give jsmin a try.

  5. petersonfs commented on May 16, 2013

    @petersonfs
    Contributor

    I'll fix it and make a pr.

    On Thursday, May 16, 2013, matt swanson wrote:

    Closure -> I think this calls a web API, not ideal.

    YUI -> needs Java installed

    I'd say let's give jsmin a try.

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/134#issuecomment-18028193
    .

    Peterson Ferreira

    • 55 41 8724 2217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions