Optimized AbundantNumber to N/2.

stringbasic · stringbasic · commit ea89bbaefe69 · 2020-01-11T20:47:10.000Z
diff --git a/src/main/java/stringbasic/exercises/AbundantNumber.java b/src/main/java/stringbasic/exercises/AbundantNumber.java
@@ -10,7 +10,7 @@ public AbundantNumber(int number) {
 
     public int abundance() {
         int result = 0;
-        for (int i = this.number-1; i>0; i--) {
+        for (int i = 1; i <= this.number/2; i++) {
             if (this.number % i == 0)
                 result += i;
         }
diff --git a/src/test/java/stringbasic/exercises/AbundantNumberTest.java b/src/test/java/stringbasic/exercises/AbundantNumberTest.java
@@ -39,5 +39,6 @@ public AbundantNumberTest(int number, int abundance, boolean isAbundant) {
     public void testKnownCases() {
         AbundantNumber sut = new AbundantNumber(this.number);
         Assert.assertEquals(this.abundance, sut.abundance());
+        Assert.assertEquals(this.isAbundant, sut.isAbundant());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public AbundantNumber(int number) {`
`10`	`10`
`11`	`11`	`public int abundance() {`
`12`	`12`	`int result = 0;`
`13`		`- for (int i = this.number-1; i>0; i--) {`
	`13`	`+ for (int i = 1; i <= this.number/2; i++) {`
`14`	`14`	`if (this.number % i == 0)`
`15`	`15`	`result += i;`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,5 +39,6 @@ public AbundantNumberTest(int number, int abundance, boolean isAbundant) {`
`39`	`39`	`public void testKnownCases() {`
`40`	`40`	`AbundantNumber sut = new AbundantNumber(this.number);`
`41`	`41`	`Assert.assertEquals(this.abundance, sut.abundance());`
	`42`	`+ Assert.assertEquals(this.isAbundant, sut.isAbundant());`
`42`	`43`	`}`
`43`	`44`	`}`