UglyNumber isUgly complete.

stringbasic · stringbasic · commit b2b95b6f44f6 · 2020-01-14T00:16:22.000+01:00
diff --git a/src/main/java/stringbasic/exercises/UglyNumber.java b/src/main/java/stringbasic/exercises/UglyNumber.java
@@ -9,6 +9,17 @@ public UglyNumber(int number) {
     }
 
     public boolean isUgly() {
+        if (this.number == 1)
+            return true;
+        canDivide(2);
+        canDivide(3);
+        canDivide(5);
+
         return this.number == 1;
     }
+
+    private void canDivide(int d) {
+        while (this.number % d == 0)
+            this.number = this.number/d;
+    }
 }
diff --git a/src/test/java/stringbasic/exercises/UglyNumberTest.java b/src/test/java/stringbasic/exercises/UglyNumberTest.java
@@ -1,14 +1,53 @@
 package stringbasic.exercises;
 
+import com.google.common.collect.ImmutableList;
 import org.junit.Assert;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
 
+import java.util.Collection;
+
+@RunWith(Parameterized.class)
 public class UglyNumberTest {
 
+    private int number;
+    private boolean isUgly;
+
+    @Parameters
+    public static Collection<Object[]> uglyNumbers () {
+        return ImmutableList.of(
+                new Object[] {12, true},
+                new Object[] {11, false},
+                new Object[] {10, true},
+                new Object[] {9, true},
+                new Object[] {8, true},
+                new Object[] {7, false},
+                new Object[] {6, true},
+                new Object[] {5, true},
+                new Object[] {4, true},
+                new Object[] {3, true},
+                new Object[] {2, true},
+                new Object[] {1, true}
+        );
+    }
+
+    public UglyNumberTest(int number, boolean isUgly) {
+        this.number = number;
+        this.isUgly = isUgly;
+    }
+
     @Test
     public void testIsUgly() {
-        int number = 1;
-        UglyNumber sut = new UglyNumber(number);
-        Assert.assertTrue(String.format("%d:", number), sut.isUgly());
+        UglyNumber sut = new UglyNumber(this.number);
+        Assert.assertEquals(
+            String.format(
+                "%d:",
+                this.number
+            ),
+            this.isUgly,
+            sut.isUgly()
+        );
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,17 @@ public UglyNumber(int number) {`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`public boolean isUgly() {`
	`12`	`+ if (this.number == 1)`
	`13`	`+ return true;`
	`14`	`+ canDivide(2);`
	`15`	`+ canDivide(3);`
	`16`	`+ canDivide(5);`
	`17`	`+`
`12`	`18`	`return this.number == 1;`
`13`	`19`	`}`
	`20`	`+`
	`21`	`+ private void canDivide(int d) {`
	`22`	`+ while (this.number % d == 0)`
	`23`	`+ this.number = this.number/d;`
	`24`	`+ }`
`14`	`25`	`}`