Skip to content

Fix stale outputs on stop#13787

Draft
harshang03 wants to merge 1 commit intostreamlit:developfrom
harshang03:fix/9904-stale-stop
Draft

Fix stale outputs on stop#13787
harshang03 wants to merge 1 commit intostreamlit:developfrom
harshang03:fix/9904-stale-stop

Conversation

@harshang03
Copy link

@harshang03 harshang03 commented Feb 2, 2026

Describe your changes

  • Keep stale elements marked during STOP_REQUESTED so stopped runs don’t appear fresh again.
  • Treat stop-requested premature exits as early finishes in the backend, preventing “successful finish” cleanup from revalidating old outputs.

Screenshot or video (only for visual changes)

Not applicable (no visual/UI changes).

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed: Changes are localized and covered by existing unit tests; no app behavior needs manual UI verification.
  • Unit Tests (JS and/or Python): Not run (recommended: cd frontend && yarn test lib/src/components/core/Block/utils.test.tsx and uv run pytest lib/tests/streamlit/runtime/scriptrunner/script_runner_test.py)
  • E2E Tests: Not run.
  • Any manual testing needed?: Not performed.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

issue: #9904

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Thanks for contributing to Streamlit! 🎈

Please make sure you have read our Contributing Guide. You can find additional information about Streamlit development in the wiki.

The review process:

  1. Initial triage: A maintainer will apply labels, approve CI to run, and trigger AI-assisted reviews. Your PR may be flagged with status:needs-product-approval if the feature requires product team sign-off.

  2. Code review: A core maintainer will start reviewing your PR once:

    • It is marked as 'ready for review', not 'draft'
    • It has status:product-approved (or doesn't need it)
    • All CI checks pass
    • All AI review comments are addressed

We're receiving many contributions and have limited review bandwidth — please expect some delay. We appreciate your patience! 🙏

@snyk-io
Copy link
Contributor

snyk-io bot commented Feb 2, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@harshang03