Movments - #1
Merged
Merged
Movments#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for handling generic data packets sent from the server to the client via the data channel. It introduces a new
on_dataevent callback, updates the relevant types and documentation, and ensures that payloads are base64-decoded before being delivered to the handler.Event and Data Handling Enhancements:
on_datacallback to theEventHandlerclass, which receives topic-addressed data packets from the server with payloads already base64-decoded. This allows clients to handle fire-and-forget server data, such as locomotion commands, in a structured way. (src/streamcore/types.py[1]README.md[2]README.zh-CN.md[3]DataChannelMessagetype to support messages of type"data", including newtopicandpayloadfields for carrying the data packet information. (src/streamcore/types.pysrc/streamcore/types.pyL60-R68)Implementation Details:
StreamCoreClientto decode base64 payloads from"data"messages and invoke theon_datacallback if set, with error handling for malformed payloads. (src/streamcore/client.pysrc/streamcore/client.pyR503-R511)base64andbinasciito support payload decoding. (src/streamcore/client.pysrc/streamcore/client.pyR4-R5)Project Versioning:
0.1.5to reflect the new feature. (pyproject.tomlpyproject.tomlL7-R7)