fix: enter key trigger in edit view form #24744
Draft
+122
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adzouz
added
source: core:content-manager
Adzouz
force-pushed
the
fix/enter-edit-view
branch
from
a866d18 to
8c23d82
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Adzouz
force-pushed
the
fix/enter-edit-view
branch
from
8c23d82 to
b0de33b
Compare
Adzouz
force-pushed
the
fix/enter-edit-view
branch
from
b0de33b to
23f1c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It fixes the action when hitting the Enter key when the focus is inside a field of the edit page view in the content manager.
Why is it needed?
It was having a weird behaviour. Hitting the enter key would trigger the first button action of the form (when internationalization enabled, it was opening the "Fill in from another locale" modal for example).
How to test it?
-> The "Fill in from another locale" shouldn't be triggered and the form should be submitted.
WAITING FOR:
Related issue(s)/PR(s)
Resolves #21377
🚀