Skip to content

Skip location for non bedrock model providers#1602

Merged
Unshure merged 2 commits intostrands-agents:mainfrom
Unshure:agent-tasks/10-2
Jan 30, 2026
Merged

Skip location for non bedrock model providers#1602
Unshure merged 2 commits intostrands-agents:mainfrom
Unshure:agent-tasks/10-2

Conversation

@Unshure
Copy link
Member

@Unshure Unshure commented Jan 30, 2026

Description

Skip and warn if location source is present for Images, Videos, or documents in non bedrock model providers

Related Issues

#1482

Documentation PR

TODO

Type of Change

New feature

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/strands/models/llamacpp.py 80.00% 1 Missing and 1 partial ⚠️
src/strands/models/writer.py 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Unshure Unshure marked this pull request as ready for review January 30, 2026 15:09
pgrayy
pgrayy previously approved these changes Jan 30, 2026
zastrowm
zastrowm previously approved these changes Jan 30, 2026
@Unshure Unshure dismissed stale reviews from zastrowm and pgrayy via 5e420d4 January 30, 2026 15:50
@github-actions github-actions bot added size/l and removed size/l labels Jan 30, 2026
@Unshure Unshure merged commit ab51706 into strands-agents:main Jan 30, 2026
15 of 16 checks passed
dbschmigelski pushed a commit to charles-dyfis-net/strands-sdk-python that referenced this pull request Feb 3, 2026
gaurav71531 pushed a commit to gaurav71531/sdk-python that referenced this pull request Feb 4, 2026
manoj-selvakumar5 pushed a commit to manoj-selvakumar5/strands-sdk-python that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants