bidi - move 3.12 check to nova sonic module#1439
Merged
pgrayy merged 1 commit intostrands-agents:mainfrom Jan 12, 2026
Merged
Conversation
pgrayy
commented
Jan 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
commented
Jan 8, 2026
pgrayy
commented
Jan 8, 2026
pgrayy
commented
Jan 8, 2026
pgrayy
commented
Jan 8, 2026
pgrayy
commented
Jan 8, 2026
pgrayy
commented
Jan 8, 2026
mehtarac
reviewed
Jan 9, 2026
zastrowm
approved these changes
Jan 12, 2026
JackYPCOnline
approved these changes
Jan 12, 2026
manoj-selvakumar5
pushed a commit
to manoj-selvakumar5/strands-sdk-python
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the bidi python 3.12+ check into the nova_sonic.py module, which is the only python 3.12+ component.
Follow Up
With these changes, we can start to remove the bidi specific build logic from the pyproject.toml (draft). We however need to do something about the pyaudio dependency first. It requires portaudio as a system level install, which can be a hassle for people to set up especially if they are contributing to unrelated components in the SDK.
Related Issues
#1299
Documentation PR
The bidi quickstart prerequisites lists 3.12+ as a requirement. Will update this line.
Type of Change
Other (please describe): Updating python version support.
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run preparehatch run bidi:preparehatch run bidi-test:test tests_integ/bidiChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.