fix: attached custom attributes to all spans#1235
Merged
poshinchen merged 1 commit intostrands-agents:mainfrom Nov 25, 2025
Merged
fix: attached custom attributes to all spans#1235poshinchen merged 1 commit intostrands-agents:mainfrom
poshinchen merged 1 commit intostrands-agents:mainfrom
Conversation
poshinchen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
poshinchen
force-pushed
the
fix/attributes-propagation
branch
from
49c14fd to
05f61da
Compare
poshinchen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
JackYPCOnline
previously approved these changes
Nov 24, 2025
afarntrog
requested changes
Nov 25, 2025
poshinchen
force-pushed
the
fix/attributes-propagation
branch
from
05f61da to
f146959
Compare
poshinchen
had a problem deploying
to
auto-approve
GitHub Actions
Failure
poshinchen
force-pushed
the
fix/attributes-propagation
branch
from
f146959 to
90faea7
Compare
poshinchen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
afarntrog
approved these changes
Nov 25, 2025
JackYPCOnline
approved these changes
Nov 25, 2025
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
JackYPCOnline
pushed a commit
to CrysisDeu/sdk-python
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When specifying custom attributes, the attributes are only added into the agent span. This change propagates the attributes to all underlying spans.
Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix / Chore change
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.