fix(litellm): populate cacheWriteInputTokens from cache_creation_input_token not cache_creation_tokens#1233
Merged
JackYPCOnline merged 1 commit intostrands-agents:mainfrom Nov 21, 2025
Conversation
…t_token not cache_creation_tokens
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
JackYPCOnline
approved these changes
Nov 21, 2025
yonib05
approved these changes
Nov 21, 2025
pgrayy
pushed a commit
to pgrayy/sdk-python
that referenced
this pull request
Nov 24, 2025
…t_token not cache_creation_tokens (strands-agents#1233)
dbschmigelski
added a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
…t_token not cache_creation_tokens (strands-agents#1233)
JackYPCOnline
pushed a commit
to CrysisDeu/sdk-python
that referenced
this pull request
Dec 19, 2025
…t_token not cache_creation_tokens (strands-agents#1233)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were previously reading from LiteLLM's PromptTokensDetailsWrapper using the
cache_creation_tokensproperty.Something, either on the Bedrock, Anthropic, or LiteLLM side, appears to not be populating that. Which was breaking the test_cache_read_tokens_multi_turn integration test for writes.
We had thought that this was possibly the result of cache being set earlier, or tests being executed by someone concurrently. But even when we set a uuid, which should be done anyway, the
cacheWriteInputTokenswere not appearing.This switches to reading from the documented
cache_creation_input_tokeninstead.Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.