security(tool_loader): prevent tool name and sys modules collisions i…#1214
Merged
JackYPCOnline merged 1 commit intostrands-agents:mainfrom Nov 21, 2025
Merged
security(tool_loader): prevent tool name and sys modules collisions i…#1214JackYPCOnline merged 1 commit intostrands-agents:mainfrom
JackYPCOnline merged 1 commit intostrands-agents:mainfrom
Conversation
dbschmigelski
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
approved these changes
Nov 20, 2025
JackYPCOnline
approved these changes
Nov 21, 2025
pgrayy
pushed a commit
to pgrayy/sdk-python
that referenced
this pull request
Nov 24, 2025
dbschmigelski
added a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
JackYPCOnline
pushed a commit
to CrysisDeu/sdk-python
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a prefix when we load modules in the tool loader. This addresses the risk that an engineer, or adversary, writes a tool with a conflicting name with an existing sys module.
Related Issues
strands-agents/docs#338
Documentation PR
strands-agents/docs#338
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.