fix(litellm): add validation for stream parameter in LiteLLM#1183
Merged
dbschmigelski merged 2 commits intostrands-agents:mainfrom Nov 17, 2025
Merged
fix(litellm): add validation for stream parameter in LiteLLM#1183dbschmigelski merged 2 commits intostrands-agents:mainfrom
dbschmigelski merged 2 commits intostrands-agents:mainfrom
Conversation
- Raise ValueError when stream is explicitly set to False - Add unit test for stream parameter validation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zastrowm
approved these changes
Nov 14, 2025
pgrayy
approved these changes
Nov 17, 2025
This was referenced Nov 17, 2025
dbschmigelski
added a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
JackYPCOnline
pushed a commit
to CrysisDeu/sdk-python
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a customer provides
stream: Falsewe fail withThis is because we are not respecting the stream parameter and are assuming the response will always come back as as CustomStreamWrapper instead of considering the actual return type of acompletion which is Union[ModelResponse, CustomStreamWrapper]
We can consider if we want to allow this in the future, but for now this fix is mainly targeting error messaging since it is currently broken.
Related Issues
#729
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.