[spi]: Keep constexpr constructor #2204
Merged
fpistm merged 8 commits intostm32duino:mainfrom Nov 24, 2023
Merged
Conversation
Keep constexpr constructor to ensures that constructing an SPISettings object can be done at compiletime. Fixes stm32duino#2201. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This parameter should not be part of SPISettings. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Since internal CS pin removed. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Linked to stm32duino#912. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
for backward compatibility. Example with Adafruit GFX Library library. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Member
Author
|
Tested with Radiolib with success using Nucleo WL55JC1 and LoRa E5 mini. Note to have generic sketch example use the static const uint32_t rfswitch_pins[] = { LORAWAN_RFSWITCH_PINS
#if LORAWAN_RFSWITCH_PIN_COUNT == 2
,
RADIOLIB_NC
#endif
};
static const Module::RfSwitchMode_t rfswitch_table[] = {
{ STM32WLx::MODE_IDLE, { LORAWAN_RFSWITCH_OFF_VALUES } },
{ STM32WLx::MODE_RX, { LORAWAN_RFSWITCH_RX_VALUES } },
{ STM32WLx::MODE_TX_LP, { LORAWAN_RFSWITCH_RFO_LP_VALUES } },
{ STM32WLx::MODE_TX_HP, { LORAWAN_RFSWITCH_RFO_HP_VALUES } },
END_OF_MODE_TABLE,
};
|
Aymane-ST
added a commit
to Aymane-ST/ArduinoCore-API
that referenced
this pull request
Jan 21, 2026
SPISettings was originally implemented with init_AlwaysInline / init_MightInline helpers, using runtime initialization only. This change: - removes init_AlwaysInline / init_MightInline helpers, - replaces them with constexpr constructors that directly initialize the members, - keeps the existing API surface refs: stm32duino/Arduino_Core_STM32#2204 stm32duino/Arduino_Core_STM32#2201
Aymane-ST
added a commit
to Aymane-ST/ArduinoCore-API
that referenced
this pull request
Jan 23, 2026
SPISettings was originally implemented with init_AlwaysInline / init_MightInline helpers, using runtime initialization only. This change: - removes init_AlwaysInline / init_MightInline helpers, - replaces them with constexpr constructors that directly initialize the members, - keeps the existing API surface refs: stm32duino/Arduino_Core_STM32#2204 stm32duino/Arduino_Core_STM32#2201
Aymane-ST
added a commit
to stm32duino/ArduinoCore-API
that referenced
this pull request
Jan 26, 2026
SPISettings was originally implemented with init_AlwaysInline / init_MightInline helpers, using runtime initialization only. This change: - removes init_AlwaysInline / init_MightInline helpers, - replaces them with constexpr constructors that directly initialize the members, - keeps the existing API surface refs: stm32duino/Arduino_Core_STM32#2204 stm32duino/Arduino_Core_STM32#2201 Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to ensures that constructing an SPISettings object can be done at compiletime.
This PR also:
Fixes #2201.