Ticket #863 rewrite toString with StringBuilder for better performance #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closed in favour of #867 as it has comparable or even better performance with way less code changes and no code duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #863
Using a StringBuilder to improve the performance for the default
toStringmethods without indent.This duplicates a lot of code, as I assume you want to keep the existing public method interfaces accepting and returning a
Writerfor backwards compatibility. But is results in ~25% fastertoStringmethod, mostly used for serialisation.I validated the performance with this project: https://github.com/fabienrenaud/java-json-benchmark
./run ser --libs ORGJSONon my local machine result for the benchmark (thoughput measured in operations per second, higher is better):
currently latest library version 20240205:
Improved implementation from this PR: