limited ctor change for 153 #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
If you are referring to the JSONObject(Map<String,?>) ctor, agreed, it was an unnecessary change. Having polled my Java gurus, the consensus is that, if a change should be made at all, Map<?,?>, Collection<?> is the best solution for #153. |
Owner
Author
|
Going with the original proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not proposing this for the #153 bug fix at this time. Just wanted to open it for comments and be able to reference it from other branches. This branch changes the ctors and some put() methods to support JSONObject(Map<String, ?>) and JSONArray(Collection<?>) in the style of #153, but makes no other changes. In order complete the unit tests, JSONObjectTest instances of Map<?,?> have to be changed to Map<String, ?>