Wildcard generics in Collection and Map arguments #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with some generics in some function/constructor arguments: for example the constructor
won't be catched by:
but it catches this constructor
public JSONArray(Object array)and so it throws this exception:The reason is that
Collection<Object>doesn't match all kinds of collections.The correct way to reference collections of all type of objects would be
Collection<? extends Object>or more conciselyCollection<?>Hope to see this patch applied because I have a lot of code that gets the above mentioned exception since constructors changed from
public JSONArray(Collection collection)topublic JSONArray(Collection<Object> collection)