Adjustments to tests for https://github.com/stleary/JSON-java/pull/337 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, will merge when stleary/JSON-java#337 is merged. |
stleary
changed the title
Contributor
Author
|
this one is for 337, not 336. |
johnjaylward
changed the title
Owner
|
Sorry, just assumed this was the fix for the broken increment test in 336 (branch johnjaylward-fixSpelling), but I did not actually execute the test to make sure. |
Contributor
Author
|
#70 fixes the increment tests |
Owner
|
Thanks, I think the comments and links are corrected now |
Contributor
Author
|
I believe these tests cover what we need. |
Owner
|
OK to merge after stleary/JSON-java#337 |
added 5 commits
May 18, 2017 11:38
…ouble method is not robust enough for large numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.