bpo-38876: Raise pickle.UnpicklingError when loading an item from mem…#47
Merged
sthagen merged 0 commit intosthagen:masterfrom Nov 24, 2019
Merged
bpo-38876: Raise pickle.UnpicklingError when loading an item from mem…#47sthagen merged 0 commit intosthagen:masterfrom
sthagen merged 0 commit intosthagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o for invalid input (pythonGH-17335)
The previous code was raising a
KeyErrorfor both the Python and C implementation.This was caused by the specified index of an invalid input which did not exist
in the memo structure, where the pickle stores what objects it has seen.
The malformed input would have caused either a
BINGETorLONG_BINGETloadfrom the memo, leading to a
KeyErroras the determined index was bogus.https://bugs.python.org/issue38876
https://bugs.python.org/issue38876