bpo-39104: Fix hanging ProcessPoolExecutor on shutdown nowait with pi…#252
Merged
sthagen merged 1 commit intosthagen:masterfrom Feb 16, 2020
Merged
bpo-39104: Fix hanging ProcessPoolExecutor on shutdown nowait with pi…#252sthagen merged 1 commit intosthagen:masterfrom
sthagen merged 1 commit intosthagen:masterfrom
Conversation
…ckling failure (GH-17670) As reported initially by @rad-pat in #6084, the following script causes a deadlock. ``` from concurrent.futures import ProcessPoolExecutor class ObjectWithPickleError(): """Triggers a RuntimeError when sending job to the workers""" def __reduce__(self): raise RuntimeError() if __name__ == "__main__": e = ProcessPoolExecutor() f = e.submit(id, ObjectWithPickleError()) e.shutdown(wait=False) f.result() # Deadlock on get ``` This is caused by the fact that the main process is closing communication channels that might be necessary to the `queue_management_thread` later. To avoid this, this PR let the `queue_management_thread` manage all the closing. https://bugs.python.org/issue39104 Automerge-Triggered-By: @pitrou
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ckling failure (pythonGH-17670)
As reported initially by @rad-pat in python#6084, the following script causes a deadlock.
This is caused by the fact that the main process is closing communication channels that might be necessary to the
queue_management_threadlater. To avoid this, this PR let thequeue_management_threadmanage all the closing.https://bugs.python.org/issue39104
Automerge-Triggered-By: @pitrou