Skip to content

Review/mp/fix warnings - #49

Merged
mpictor merged 12 commits into
masterfrom
review/mp/fix-warnings
Aug 24, 2011
Merged

Review/mp/fix warnings#49
mpictor merged 12 commits into
masterfrom
review/mp/fix-warnings

Conversation

@mpictor

@mpictor mpictor commented Aug 20, 2011

Copy link
Copy Markdown
Member

Fix all but one of the remaining warnings.

Fixes #2

@mpictor

mpictor commented Aug 21, 2011

Copy link
Copy Markdown
Member Author

with cc155a8, this fixes all warnings but #48. for real this time.

@tpaviot

tpaviot commented Aug 23, 2011

Copy link
Copy Markdown
Member

+1

@tpaviot

tpaviot commented Aug 23, 2011

Copy link
Copy Markdown
Member

Sorry, I +1'd too quickly. This branch actually does not compile:

$ cmake-gui ..
$ make 2>build-err.txt
$ more build-err.txt
/usr/bin/bison: invalid option -- W
Try `/usr/bin/bison --help' for more information.
make[2]: *** [src/express/expparse.c] Error 1
make[1]: *** [src/express/CMakeFiles/express.dir/all] Error 2
make: *** [all] Error 2

@tpaviot

tpaviot commented Aug 23, 2011

Copy link
Copy Markdown
Member

FYI,

$ bison --version
bison (GNU Bison) 2.3
Written by Robert Corbett and Richard Stallman.

Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@tpaviot

tpaviot commented Aug 23, 2011

Copy link
Copy Markdown
Member

-Wallis not an option of OSX bison:

$ bison --help
$ bison --help
GNU bison generates parsers for LALR(1) grammars.

Usage: bison [OPTION]... FILE

If a long option shows an argument as mandatory, then it is mandatory
for the equivalent short option also.  Similarly for optional arguments.

Operation modes:
  -h, --help                 display this help and exit
  -V, --version              output version information and exit
      --print-localedir      output directory containing locale-dependent data
  -y, --yacc                 emulate POSIX yacc

Parser:
  -S, --skeleton=FILE        specify the skeleton to use
  -t, --debug                instrument the parser for debugging
      --locations            enable locations computation
  -p, --name-prefix=PREFIX   prepend PREFIX to the external symbols
  -l, --no-lines             don't generate `#line' directives
  -n, --no-parser            generate the tables only
  -k, --token-table          include a table of token names

Output:
  -d, --defines              also produce a header file
  -r, --report=THINGS        also produce details on the automaton
  -v, --verbose              same as `--report=state'
  -b, --file-prefix=PREFIX   specify a PREFIX for output files
  -o, --output=FILE          leave output to FILE
  -g, --graph                also produce a VCG description of the automaton

THINGS is a list of comma separated words that can include:
  `state'        describe the states
  `itemset'      complete the core item sets with their closure
  `look-ahead'   explicitly associate look-ahead tokens to items
  `solved'       describe shift/reduce conflicts solving
  `all'          include all the above information
  `none'         disable the report

@mpictor

mpictor commented Aug 23, 2011

Copy link
Copy Markdown
Member Author

@tpaviot - what do you think of a625429?

@tpaviot

tpaviot commented Aug 24, 2011

Copy link
Copy Markdown
Member

Perfect.

+1 for merging.

mpictor added a commit that referenced this pull request Aug 24, 2011
@mpictor
mpictor merged commit 2c8cbc3 into master Aug 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expscan.l:402: warning, rule cannot be matched

2 participants