Conversation
Contributor
Author
|
@StefanRijnhart @NL66278 might be interested in this |
Owner
|
Good job @hbrunn. Had it on my todo list for the end of the month :) Perhaps it's a good idea to also implement the unique address ID in the result, in case you want to compare the result address to a previous fetched one. |
Contributor
Author
|
thanks for the merge! |
Collaborator
|
Excellent, @hbunn! Is there a reason to default to v1? Defaulting to v2 now saves everyone another software update before march. |
Contributor
Author
|
@StefanRijnhart you need a new api key for v2, so I figured it might be more convenient to have users not needing to change anything right now, but only when v1 is dead for good |
Collaborator
|
Ah, I see. |
Collaborator
|
@steffex care to attempt a release on Pypi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation to support the v2 api (http://www.postcodeapi.nu/docs/)
For now, the default is v1, but we can change this to v2 when v1 will be deactivated in March