feat: add math/base/special/ahaversinf#3076
Merged
Planeshifter merged 9 commits intostdlib-js:developfrom Nov 10, 2024
Merged
Conversation
Member
Author
|
ready for review @Planeshifter ! |
Planeshifter
reviewed
Nov 9, 2024
lib/node_modules/@stdlib/math/base/special/ahaversinf/lib/main.js
Outdated
Show resolved
Hide resolved
Planeshifter
requested changes
Nov 9, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for your PR, @aayush0325! Left one comment concerning the implementation, otherwise this is looking good.
Planeshifter
added
Needs Changes
1 task
Member
Author
|
kindly let me know if i should add |
Planeshifter
approved these changes
Nov 10, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks again for your contribution and the changes! WIll merge shortly.
Planeshifter
added
Ready To Merge
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
aayush0325
added a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
PR-URL: stdlib-js#3076 Ref: stdlib-js#649 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #649.
Description
This pull request:
math/base/special/ahaversinfRelated Issues
This pull request:
Questions
No.
Other
Open to reviews!!
Checklist
@stdlib-js/reviewers