feat: add ndarray/base/map#2715
Conversation
|
@kgryte As discussed, I've implemented the kernels up to 3d and the related files. Please review. |
…/headlessNode/2715
…/headlessNode/2715
|
@headlessNode Thanks for working on this. What you have thus far looks great! Just made some minor edits to ensure the descriptions/conventions match other similar packages. Should be good to continue building this out. 🚀 |
…o ndarray-base-map
|
@kgryte All kernels implemented. Please review, thanks! |
|
@headlessNode Am I right in thinking that you'd like a review before we add tests? |
|
@kgryte Yes. But if you'd prefer, I can implement the tests before your review. |
|
I think you are right to wait, lest we need to make any changes. |
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
LGTM. @headlessNode I think we can go ahead and merge this and then add tests in a follow-up PR. That work for you?
|
Re: the failing benchmarks CI job. I can confirm that the benchmarks run as expected. I ran them locally and all succeeded. Given the number of benchmarks, we're simply at the mercy of GitHub CI time limits. |
|
@kgryte I have started to work on the tests. I'll open a PR when completed.
Yes, I also checked multiple times on my end ran as expected. |
|
Great! I'll go ahead and merge! 🚀 |
|
Lots of learning with this one. Thanks for your help @kgryte |
|
Awesome! I know it's a slog, so thanks for persisting! |
PR-URL: stdlib-js#2715 Ref: stdlib-js#2656 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
2 participants
Progresses #2656.
Description
This pull request:
baseimplementation ofArray.prototype.mapmethod forndarraysRelated Issues
This pull request:
Questions
No.
Other
This is a work-in-progress pull request.
Checklist
@stdlib-js/reviewers