Skip to content

chore: fix JavaScript lint errors (issue #11183)#11187

Open
tranhoangtu-it wants to merge 1 commit intostdlib-js:developfrom
tranhoangtu-it:fix/no-new-array-try-then-11183
Open

chore: fix JavaScript lint errors (issue #11183)#11187
tranhoangtu-it wants to merge 1 commit intostdlib-js:developfrom
tranhoangtu-it:fix/no-new-array-try-then-11183

Conversation

@tranhoangtu-it
Copy link
Copy Markdown

@tranhoangtu-it tranhoangtu-it commented Mar 28, 2026

Summary

Fix two stdlib/no-new-array lint violations in @stdlib/utils/async/try-then/lib/main.js.

Changes

Replace new Array(nargs) with [] and indexed assignment with args.push() equivalents.

-  args = new Array( nargs );
-  args[ 0 ] = null;
-  for ( i = 1; i < nargs; i++ ) { args[ i ] = arguments[ i ]; }
+  args = [];
+  args.push( null );
+  for ( i = 1; i < nargs; i++ ) { args.push( arguments[ i ] ); }

Closes #11183

Copilot AI review requested due to automatic review settings March 28, 2026 08:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 28, 2026
@tranhoangtu-it
Copy link
Copy Markdown
Author

Updated the PR description with the contributing guidelines acknowledgment. Thank you for the reminder!

@github-actions github-actions bot mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants