feat: add stats/strided/snanmeankbn#11116
Open
parthodas23 wants to merge 2 commits intostdlib-js:developfrom
Open
feat: add stats/strided/snanmeankbn#11116parthodas23 wants to merge 2 commits intostdlib-js:developfrom
stats/strided/snanmeankbn#11116parthodas23 wants to merge 2 commits intostdlib-js:developfrom
Conversation
dab1ccc to
90413de
Compare
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
4503ca0 to
6f1b8e3
Compare
Om-A-osc
reviewed
Mar 24, 2026
Contributor
Om-A-osc
left a comment
There was a problem hiding this comment.
Hey @parthodas23. I have left some comments on you PR. Happy to give my first code review in stdlib on your PR.
Comment on lines
+297
to
+301
|
|
||
| - <span class="package-name">[`@stdlib/stats/strided/dmeankbn`][@stdlib/stats/strided/dmeankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a double-precision floating-point strided array using an improved Kahan–Babuška algorithm.</span> | ||
| - <span class="package-name">[`@stdlib/stats/strided/smeankbn`][@stdlib/stats/strided/smeankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.</span> | ||
| - <span class="package-name">[`@stdlib/stats/strided/meankbn`][@stdlib/stats/strided/meankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a strided array using an improved Kahan–Babuška algorithm.</span> | ||
|
|
Contributor
There was a problem hiding this comment.
This needs to be removed. The see also section in README.md is not supposed to be filled manually.
| // MODULES // | ||
|
|
||
| var stride2offset = require( '@stdlib/strided/base/stride2offset' ); | ||
| var ndarray = require( '@stdlib/stats/strided/snanmeankbn/lib/ndarray.js' ); |
Contributor
There was a problem hiding this comment.
Suggested change
| var ndarray = require( '@stdlib/stats/strided/snanmeankbn/lib/ndarray.js' ); | |
| var ndarray = require( './ndarray.js' ); |
Contributor
Author
|
@Om-A-osc Done, thanks for the review. ❤️ |
dfe3f3b to
cdbecf5
Compare
stats/strided/snanmeankbnstats/strided/snanmeankbn
cdbecf5 to
936fe44
Compare
936fe44 to
ad1736f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #346 .
Description
This pull request:
stats/strided/snanmeankbnstats/strided/snanmeankbnRelated Issues
This pull request has the following related issues:
stats/strided/snanmeankbn#346Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers