fix: fixed parsing for node#66
Merged
niftylettuce merged 5 commits intostacktracejs:masterfrom Feb 2, 2022
Merged
Conversation
…cation in brackets
…edLine' and 'location'
Contributor
|
@Aleksey28 I wanted to follow up - I haven't had a chance to closely review this - but I would love to merge. Is this ready to go? I see you haven't checked off two checkboxes in the checklist above (docs and running that script without errors). |
niftylettuce
requested changes
Jan 17, 2022
Contributor
niftylettuce
left a comment
There was a problem hiding this comment.
See my comment (you didn't check off two checkboxes yet in the GH issue template).
Contributor
Author
|
@niftylettuce Yes, it's ready to go. I haven't checked because they're unnecessary and they just were in the template of the PR. I think it outdated checkboxes
|
Contributor
|
Ping @eriwen for npm owner access so I can publish v2.0.7 via |
Contributor
|
v2.0.7 published, thanks again @eriwen 🙏 cc @Aleksey28 https://github.com/stacktracejs/error-stack-parser/releases/tag/v2.0.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
I have a problem with the Node.js product. In some ways error looks like this:
First-line doesn't have a function name and round brackets and it loses full file name after splitting.
How Has This Been Tested?
Added new option for test 'should handle spaces in Node.js stacks'
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc error-stack-parser.jspasses without errorsnpm testpasses without errors