Skip to content

ROX-14129,ROX-14130,ROX-14131,ROX-14132: Fix failing boolean policy test. #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhaus67 merged 1 commit into from
Jan 2, 2023
Merged

ROX-14129,ROX-14130,ROX-14131,ROX-14132: Fix failing boolean policy test. #4253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/booleanpolicy/evaluator/evaluator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,7 @@ func TestDifferentBaseTypes(t *testing.T) {
FieldQueries: []*query.FieldQuery{
// This test will fail in three years, but if this test still matters then,
// we have other problems...
{Field: "BaseTS", Values: []string{">1000d"}},
{Field: "BaseTS", Values: []string{">2000d"}},
Copy link
Copy Markdown
Contributor

@porridge porridge Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this as well as the comment to 1000y instead (or if that does not fit, 100y).

Copy link
Copy Markdown
Contributor Author

@dhaus67 dhaus67 Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I oversaw this one before merging, created a follow-up for this: #4255.
Sorry!

},
},
},
Expand Down