Skip to content

Fix TLSChallenge certificate test flake and increase cert expiry date…#3864

Merged
janisz merged 1 commit intorelease-3.73from
release-3.73.x/sb/fix-certificate-test-flake
Nov 21, 2022
Merged

Fix TLSChallenge certificate test flake and increase cert expiry date…#3864
janisz merged 1 commit intorelease-3.73from
release-3.73.x/sb/fix-certificate-test-flake

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Nov 21, 2022

Cherry-pick 22fc678

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Nov 21, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3038032 Generic High Entropy Secret 840d226 sensor/common/centralclient/client_test.go View secret
3038032 Generic High Entropy Secret 840d226 sensor/common/centralclient/client_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Nov 21, 2022

/test all

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Nov 21, 2022

/test ci/prow/ui-unit-tests

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 21, 2022

@janisz: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test go-unit-tests-release
  • /test images
  • /test stackrox_branding-images
  • /test style-checks
  • /test ui-unit-tests

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/ui-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Nov 21, 2022

/test ci/prow/style-checks

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 21, 2022

@janisz: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test go-unit-tests-release
  • /test images
  • /test stackrox_branding-images
  • /test style-checks
  • /test ui-unit-tests

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/style-checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Nov 21, 2022

/test ci/prow/go-unit-tests-release

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 21, 2022

@janisz: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test go-unit-tests-release
  • /test images
  • /test stackrox_branding-images
  • /test style-checks
  • /test ui-unit-tests

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/go-unit-tests-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janisz janisz merged commit d074a21 into release-3.73 Nov 21, 2022
@janisz janisz deleted the release-3.73.x/sb/fix-certificate-test-flake branch November 21, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants