Fix TLSChallenge certificate test flake and increase cert expiry date#3843
Fix TLSChallenge certificate test flake and increase cert expiry date#3843SimonBaeumer merged 6 commits intomasterfrom
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 3038032 | Generic High Entropy Secret | f219ff0 | sensor/common/centralclient/client_test.go | View secret |
| 3038032 | Generic High Entropy Secret | f219ff0 | sensor/common/centralclient/client_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| // 1. Deploy a new StackRox instance | ||
| // 2. Create and generate a new CA and replace it in the additional-ca.yaml: | ||
| // $ openssl genrsa -des3 -out myCA.key 2048 | ||
| // $ openssl req -x509 -new -nodes -key myCA.key -sha256 -days 1825 -out myCA.pem -days 100000 -subj '/CN=Root LoadBalancer Certificate Authority' |
There was a problem hiding this comment.
Shall we set a reminder in our calendars for 1st of September 2296, so that we don't forget to renew? 😉
|
Why is there an empty |
|
Images are ready for the commit at 65676c2. To use with deploy scripts, first |
|
@SimonBaeumer: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Merge commit has been cherry-picked to branch |
|
Please merge the changes to branch |
1 similar comment
|
Please merge the changes to branch |
5 participants
Description
Fix TLSChallenge certificate test flake and increase cert expiry date.
The cert expires now after ~200years for the load balancer.
Additionally the documentation was improved to make it easier to exchange certificates if necessary.
Checklist
Evaluated and added CHANGELOG entry if requiredDetermined and documented upgrade stepsDocumented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed