Skip to content

ROX-13345: disable 'missing required registry' aspect on openshift #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
porridge merged 2 commits into from
Nov 15, 2022
Merged

ROX-13345: disable 'missing required registry' aspect on openshift #3798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cefd15
ROX-13345: disable 'missing required registry' aspect on openshift
porridge Nov 14, 2022
edce334
break line to keep linter happy
porridge Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions qa-tests-backend/src/test/groovy/ImageScanningTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,8 @@ class ImageScanningTest extends BaseSpecification {
@Category(Integration)
def "Verify image scan exceptions - #scanner.name() - #testAspect"() {
Assume.assumeTrue(scanner.isTestable())
Assume.assumeFalse(
testAspect == "missing required registry" && Env.mustGetOrchestratorType() == OrchestratorTypes.OPENSHIFT)
Copy link
Copy Markdown
Contributor

@janisz janisz Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have TODO here with issue about reenabling this test?

Copy link
Copy Markdown
Contributor Author

@porridge porridge Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that in another PR and our linter did not like it that much.
But if you insist, I think we can work that around by creating a subtask and putting a TODO with that.

cleanupSetupForRetry()

when:
Expand Down