Skip to content

ROX-13505: Fix error log scanning the postgres stat collection #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-du merged 2 commits into from
Nov 14, 2022
Merged

ROX-13505: Fix error log scanning the postgres stat collection #3795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24beef1
build
c-du Nov 11, 2022
41b31a2
Fix error scanning log
c-du Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions central/globaldb/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ SELECT TABLE_NAME
, SUM(c.reltuples) OVER (partition BY parent) AS row_estimate
, SUM(pg_total_relation_size(c.oid)) OVER (partition BY parent) AS total_bytes
, SUM(pg_indexes_size(c.oid)) OVER (partition BY parent) AS index_bytes
, SUM(pg_total_relation_size(reltoastrelid)) OVER (partition BY parent) AS toast_bytes
, SUM(COALESCE(pg_total_relation_size(reltoastrelid), 0)) OVER (partition BY parent) AS toast_bytes
Copy link
Copy Markdown
Contributor

@RTann RTann Nov 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if it should be this instead:

COALESCE(SUM(pg_total_relation_size(reltoastrelid)) OVER (partition BY parent), 0) AS toast_bytes

I haven't tested it, but I'm curious if they both give the same results or if one is more efficient than the other

, parent
FROM (
SELECT pg_class.oid
Expand Down Expand Up @@ -131,7 +131,7 @@ func collectPostgresStats(ctx context.Context, db *pgxpool.Pool) {
tableSize int
)
if err := row.Scan(&tableName, &rowEstimate, &totalSize, &indexSize, &toastSize, &tableSize); err != nil {
log.Errorf("error scanning row: %v", err)
log.Errorf("error scanning row for table %s: %v", tableName, err)
return
}

Expand Down