Skip to content

ROX-13067: fill out port configurations section of deployment details #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachaudh merged 1 commit into from
Nov 11, 2022
Merged

ROX-13067: fill out port configurations section of deployment details #3714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 146 additions & 0 deletions ui/apps/platform/src/Components/DeploymentPortConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
import React, { useState } from 'react';
import {
Card,
CardBody,
DescriptionList,
DescriptionListDescription,
DescriptionListGroup,
DescriptionListTerm,
ExpandableSection,
Stack,
StackItem,
} from '@patternfly/react-core';

import { PortConfig } from 'types/deployment.proto';

type DeploymentPortConfigProps = {
port: PortConfig;
};

function DeploymentPortConfig({ port }: DeploymentPortConfigProps) {
const [isExpanded, setIsExpanded] = useState(false);

const onToggle = (_isExpanded: boolean) => {
setIsExpanded(_isExpanded);
};

return (
<ExpandableSection
toggleText={port.name}
onToggle={onToggle}
isExpanded={isExpanded}
displaySize="large"
isWidthLimited
>
<Stack hasGutter>
<StackItem>
<DescriptionList columnModifier={{ default: '2Col' }} isCompact>
<DescriptionListGroup>
<DescriptionListTerm>Container port</DescriptionListTerm>
<DescriptionListDescription>
{port.containerPort}
</DescriptionListDescription>
</DescriptionListGroup>
Copy link
Copy Markdown
Contributor

@alwayshooin alwayshooin Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i just remembered i made a component called DescriptionListItem.tsx that basically wraps the term and description in the group into one component if you wanted to simplify the code here a bit

<DescriptionListGroup>
<DescriptionListTerm>Protocol</DescriptionListTerm>
<DescriptionListDescription>{port.protocol}</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Exposure</DescriptionListTerm>
<DescriptionListDescription>{port.exposure}</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Exposed port</DescriptionListTerm>
<DescriptionListDescription>
{port.exposedPort}
</DescriptionListDescription>
</DescriptionListGroup>
</DescriptionList>
</StackItem>
<StackItem>
<Stack hasGutter>
{port.exposureInfos.map((exposureInfo) => {
return (
<StackItem>
<Card isFlat>
<CardBody>
<DescriptionList
columnModifier={{ default: '2Col' }}
isCompact
>
<DescriptionListGroup>
<DescriptionListTerm>Level</DescriptionListTerm>
<DescriptionListDescription>
{exposureInfo.level}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Service Name
</DescriptionListTerm>
<DescriptionListDescription>
{exposureInfo.serviceName}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Service ID
</DescriptionListTerm>
<DescriptionListDescription>
{exposureInfo.serviceId}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Service Cluster IP
</DescriptionListTerm>
<DescriptionListDescription>
{exposureInfo.serviceClusterIp}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Service Port
</DescriptionListTerm>
<DescriptionListDescription>
{exposureInfo.servicePort}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Node Port
</DescriptionListTerm>
<DescriptionListDescription>
{exposureInfo.nodePort}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
External IPs
</DescriptionListTerm>
<DescriptionListDescription>
-
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
External Hostnames
</DescriptionListTerm>
<DescriptionListDescription>
-
</DescriptionListDescription>
</DescriptionListGroup>
</DescriptionList>
</CardBody>
</Card>
</StackItem>
);
})}
</Stack>
</StackItem>
</Stack>
</ExpandableSection>
);
}

export default DeploymentPortConfig;
55 changes: 53 additions & 2 deletions ui/apps/platform/src/Containers/NetworkGraph/deployment/DeploymentDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,60 @@ import {
import { ExclamationCircleIcon } from '@patternfly/react-icons';
import pluralize from 'pluralize';

import { Deployment } from 'types/deployment.proto';
import { Deployment, PortConfig } from 'types/deployment.proto';
import { ListenPort } from 'types/networkFlow.proto';
import { getDateTime } from 'utils/dateUtils';

import DeploymentPortConfig from 'Components/DeploymentPortConfig';

type DeploymentDetailsProps = {
deployment: Deployment;
numExternalFlows: number;
numInternalFlows: number;
listenPorts: ListenPort[];
};

const mockPorts: PortConfig[] = [
{
name: 'api',
containerPort: 8443,
protocol: 'TCP',
exposure: 'INTERNAL',
exposedPort: 0,
exposureInfos: [
{
level: 'INTERNAL',
serviceName: 'sensor',
serviceId: 'b830c97f-7ecf-49c7-898c-ea9c68f2e131',
serviceClusterIp: '10.73.232.126',
servicePort: 443,
nodePort: 0,
externalIps: [],
externalHostnames: [],
},
],
},
{
name: 'webhook',
containerPort: 9443,
protocol: 'TCP',
exposure: 'INTERNAL',
exposedPort: 0,
exposureInfos: [
{
level: 'INTERNAL',
serviceName: 'sensor-webhook',
serviceId: '3d879536-0521-4a52-9a8e-d33b4aa75ca5',
serviceClusterIp: '10.73.232.21',
servicePort: 443,
nodePort: 0,
externalIps: [],
externalHostnames: [],
},
],
},
];

function DetailSection({ title, children }) {
const [isExpanded, setIsExpanded] = useState(true);

Expand Down Expand Up @@ -248,7 +291,15 @@ function DeploymentDetails({
<Divider component="li" className="pf-u-mb-sm" />
<li>
<DetailSection title="Port configurations">
@TODO: Add port configurations section
<Stack hasGutter>
{mockPorts.map((port) => {
return (
<StackItem>
<DeploymentPortConfig port={port} />
</StackItem>
);
})}
</Stack>
</DetailSection>
</li>
</ul>
Expand Down