Skip to content

ROX-11931: Convert junit failure artifacts to Slack attachments #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BradLugo merged 19 commits into from
Nov 10, 2022
Merged

ROX-11931: Convert junit failure artifacts to Slack attachments #3438

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
76d9297
WIP
BradLugo Oct 14, 2022
822ce1a
WIP
BradLugo Oct 17, 2022
03fc443
PR feedback
BradLugo Oct 18, 2022
6887f1e
Fix empty failure messages
BradLugo Oct 18, 2022
ddcdea8
Change Slack payload to include the attachments
BradLugo Oct 18, 2022
a20870c
PR feedback
BradLugo Oct 18, 2022
dad772d
Fix shell style
BradLugo Oct 19, 2022
16b32cf
Remove unit test
BradLugo Oct 19, 2022
801118a
Only grab the first three failure messages
BradLugo Oct 19, 2022
b75dd10
Revert "Remove unit test"
BradLugo Oct 19, 2022
0091da7
PR feedback
BradLugo Oct 19, 2022
9182fd5
Separate junit2slack to different repo
BradLugo Oct 25, 2022
2988865
Change commit hash of junit-parse for testing
BradLugo Oct 25, 2022
bd68fac
PR feedback
BradLugo Oct 26, 2022
7d59951
CI testing
BradLugo Oct 26, 2022
f02fd0e
Revert "CI testing"
BradLugo Nov 9, 2022
fb278dd
Add fixes from CI testing
BradLugo Nov 9, 2022
3e7d52e
PR feedback
BradLugo Nov 9, 2022
d416a4c
Fix shell style issues
BradLugo Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion scripts/ci/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,6 +1299,39 @@ __EOM__
slack_mention="_unable to resolve Slack user for GitHub login ${author_login}_"
fi

info "Converting junit failures to slack attachments"

local slack_attachments='
[
{
"color": "#bb2124",
"blocks": [
{
"type": "section",
"text": {
"type": "plain_text",
"text": "Could not parse junit files. Check build logs for more information.
}
}
]
}
]
'
if [[ -n "${ARTIFACT_DIR}" ]]; then
if ! command -v junit-parse >/dev/null 2>&1; then
get_junit_parse_cli || true
fi
if command -v junit-parse >/dev/null 2>&1; then
local junit_file_names
junit_file_names=( "$(find "${ARTIFACT_DIR}" -type f -name '*.xml' -print0 | xargs -0)" ) || true
local check_slack_attachments
check_slack_attachments=$(junit-parse "${junit_file_names[@]}") || exitstatus="$?"
if [[ "$exitstatus" == "0" ]]; then
slack_attachments="$check_slack_attachments"
fi
fi
fi

# shellcheck disable=SC2016
local body='
{
Expand Down Expand Up @@ -1330,7 +1363,8 @@ __EOM__
{
"type": "divider"
}
]
],
"attachments": $slack_attachments
}
'

Expand All @@ -1342,6 +1376,7 @@ __EOM__
--arg author_name "$author_name" \
--arg slack_mention "$slack_mention" \
--arg log_url "$log_url" \
--argjson slack_attachments "$slack_attachments" \
"$body")"
echo -e "About to post:\n$payload"

Expand Down Expand Up @@ -1433,6 +1468,10 @@ EOT
hub-comment -type build -template-file "$tmpfile"
}

get_junit_parse_cli() {
go install github.com/stackrox/junit-parse
}

if [[ "${BASH_SOURCE[0]}" == "$0" ]]; then
if [[ "$#" -lt 1 ]]; then
die "When invoked at the command line a method is required."
Expand Down