Skip to content

Simplify configmanagement integration tests #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrottimark merged 1 commit into from
Oct 4, 2022
Merged

Simplify configmanagement integration tests #3295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions ui/apps/platform/cypress/integration/configmanagement/ciscontrols.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ import {
} from '../../constants/ConfigManagementPage';
import withAuth from '../../helpers/basicAuth';

// const entitiesKey = 'controls'; // omit to minimize changed lines
const entitiesKey = 'controls';

describe('Config Management Entities (CIS controls)', () => {
describe('Configuration Management Controls', () => {
withAuth();

it('should render the controls list and open the side panel when a row is clicked', () => {
Expand All @@ -29,49 +29,49 @@ describe('Config Management Entities (CIS controls)', () => {
cy.get('[data-testid="scan-button"]').click();
});

renderListAndSidePanel('controls');
renderListAndSidePanel(entitiesKey);
});

it('should take you to a control single when the "navigate away" button is clicked', () => {
renderListAndSidePanel('controls');
navigateToSingleEntityPage('controls');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
});

it('should have the correct count widgets for a single entity view', () => {
renderListAndSidePanel('controls');
navigateToSingleEntityPage('controls');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
hasCountWidgetsFor(['Nodes']);
});

it('should click on the nodes count widget in the entity page and show the nodes tab', () => {
renderListAndSidePanel('controls');
navigateToSingleEntityPage('controls');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
clickOnCountWidget('nodes', 'entityList');
});

it('should have the correct tabs for a single entity view', () => {
renderListAndSidePanel('controls');
navigateToSingleEntityPage('controls');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
hasTabsFor(['nodes']);
});

it('should have the same number of Nodes in the count widget as in the Nodes table', () => {
describe('should have same number in nodes table as in count widget', () => {
const entitiesKey2 = 'nodes';

context('Page', () => {
renderListAndSidePanel('controls');
navigateToSingleEntityPage('controls');
pageEntityCountMatchesTableRows('controls', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('controls');
sidePanelEntityCountMatchesTableRows('controls', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should show no failing nodes in the control findings section of a passing control', () => {
visitConfigurationManagementEntities('controls');
visitConfigurationManagementEntities(entitiesKey);

cy.get(configManagementSelectors.tableNextPage).click();
cy.get(configManagementSelectors.tableCells)
Expand All @@ -82,7 +82,7 @@ describe('Config Management Entities (CIS controls)', () => {
});

it('should show failing nodes in the control findings section of a failing control', () => {
visitConfigurationManagementEntities('controls');
visitConfigurationManagementEntities(entitiesKey);

cy.get(configManagementSelectors.tableCells)
.contains(controlStatus.fail)
Expand Down
156 changes: 78 additions & 78 deletions ui/apps/platform/cypress/integration/configmanagement/clusters.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,23 @@ import {
import { selectors } from '../../constants/ConfigManagementPage';
import withAuth from '../../helpers/basicAuth';

// const entitiesKey = 'clusters'; // omit to minimize changed lines
const entitiesKey = 'clusters';

describe('Config Management Entities (Clusters)', () => {
describe('Configuration Management Clusters', () => {
withAuth();

it('should render the clusters list and open the side panel when a row is clicked', () => {
renderListAndSidePanel('clusters');
renderListAndSidePanel(entitiesKey);
});

it('should take you to a cluster single when the "navigate away" button is clicked', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
});

it('should have the correct count widgets for a single entity view', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
hasCountWidgetsFor([
'Nodes',
'Namespaces',
Expand All @@ -44,8 +44,8 @@ describe('Config Management Entities (Clusters)', () => {
});

it('should have the correct tabs for a single entity view', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
hasTabsFor([
'nodes',
'namespaces',
Expand All @@ -60,7 +60,7 @@ describe('Config Management Entities (Clusters)', () => {
});

it('should have items in the Findings section', () => {
visitConfigurationManagementEntities('clusters');
visitConfigurationManagementEntities(entitiesKey);

cy.get(`${selectors.tableCells}:contains(fail)`).eq(0).click();

Expand All @@ -69,123 +69,123 @@ describe('Config Management Entities (Clusters)', () => {
).should('exist');
});

it('should have the same number of Nodes in the count widget as in the Nodes table', () => {
describe('should have same number in nodes table as in count widget', () => {
const entitiesKey2 = 'nodes';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Namespaces in the count widget as in the Namespaces table', () => {
describe('should have same number in namespaces table as in count widget', () => {
const entitiesKey2 = 'namespaces';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Deployments in the count widget as in the Deployments table', () => {
describe('should have same number in deployments table as in count widget', () => {
const entitiesKey2 = 'deployments';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Images in the count widget as in the Images table', () => {
describe('should have same number in images table as in count widget', () => {
const entitiesKey2 = 'images';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Users & Groups in the count widget as in the Users & Groups table', () => {
describe('should have same number in users and groups table as in count widget', () => {
const entitiesKey2 = 'subjects';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Service Accounts in the count widget as in the Service Accounts table', () => {
describe('should have same number in service accounts table as in count widget', () => {
const entitiesKey2 = 'serviceaccounts';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Roles in the count widget as in the Roles table', () => {
describe('should have same number in roles table as in count widget', () => {
const entitiesKey2 = 'roles';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

it('should have the same number of Controls in the count widget as in the Controls table', () => {
describe('should have same number in controls table as in count widget', () => {
const entitiesKey2 = 'controls';

context('Page', () => {
renderListAndSidePanel('clusters');
navigateToSingleEntityPage('clusters');
pageEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of page', () => {
renderListAndSidePanel(entitiesKey);
navigateToSingleEntityPage(entitiesKey);
pageEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});

context('Side Panel', () => {
renderListAndSidePanel('clusters');
sidePanelEntityCountMatchesTableRows('clusters', entitiesKey2);
it('of side panel', () => {
renderListAndSidePanel(entitiesKey);
sidePanelEntityCountMatchesTableRows(entitiesKey, entitiesKey2);
});
});

Expand All @@ -197,22 +197,22 @@ describe('Config Management Entities (Clusters)', () => {
cy.get('[data-testid="scan-button"]').click();
});

entityListCountMatchesTableLinkCount('clusters', 'controls', /\d+ Controls?$/);
entityListCountMatchesTableLinkCount(entitiesKey, 'controls', /\d+ Controls?$/);
});

it('should open the side panel to show the same number of Users & Groups when the Users & Groups link is clicked', () => {
entityListCountMatchesTableLinkCount('clusters', 'subjects', /^\d+ Users & Groups$/);
entityListCountMatchesTableLinkCount(entitiesKey, 'subjects', /^\d+ Users & Groups$/);
});

it('should open the side panel to show the same number of Service Accounts when the Service Accounts link is clicked', () => {
entityListCountMatchesTableLinkCount(
'clusters',
entitiesKey,
'serviceaccounts',
/^\d+ Service Accounts?$/
);
});

it('should open the side panel to show the same number of Roles when the Roles link is clicked', () => {
entityListCountMatchesTableLinkCount('clusters', 'roles', /^\d+ Roles?$/);
entityListCountMatchesTableLinkCount(entitiesKey, 'roles', /^\d+ Roles?$/);
});
});
Loading