Skip to content

Upgrade Helm Operator version#2930

Closed
vladbologa wants to merge 1 commit intomasterfrom
vbologa/upgrade-helm-operator-version
Closed

Upgrade Helm Operator version#2930
vladbologa wants to merge 1 commit intomasterfrom
vbologa/upgrade-helm-operator-version

Conversation

@vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Sep 1, 2022

Description

The Stackrox Help Operator was rebased on top of its upstream repository

This commit changes the reference in go.mod to the new tip of the main branch.

Checklist

  • Investigated and inspected CI test results
    - [ ] Unit test and regression tests added
    - [ ] Evaluated and added CHANGELOG entry if required
    - [ ] Determined and documented upgrade steps
    - [ ] Documented user facing changes (create PR based on [openshift/openshift-docs](https://github.com/openshift/openshift-docs) and merge into rhacs-docs)~~

Testing Performed

CI should be sufficient

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

@vladbologa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/grouped-static-checks 17a39ec link true /test grouped-static-checks
ci/prow/go-postgres-tests 17a39ec link true /test go-postgres-tests
ci/prow/openshift-newest-qa-e2e-tests 17a39ec link false /test openshift-newest-qa-e2e-tests
ci/prow/policy-checks 17a39ec link true /test policy-checks
ci/prow/gke-postgres-qa-e2e-tests 17a39ec link false /test gke-postgres-qa-e2e-tests
ci/prow/gke-ui-e2e-tests 17a39ec link false /test gke-ui-e2e-tests
ci/prow/gke-scale-tests 17a39ec link false /test gke-scale-tests
ci/prow/gke-upgrade-tests 17a39ec link false /test gke-upgrade-tests
ci/prow/gke-qa-e2e-tests 17a39ec link false /test gke-qa-e2e-tests
ci/prow/gke-nongroovy-e2e-tests 17a39ec link false /test gke-nongroovy-e2e-tests
ci/prow/gke-kernel-qa-e2e-tests 17a39ec link false /test gke-kernel-qa-e2e-tests
ci/prow/gke-postgres-upgrade-tests 17a39ec link false /test gke-postgres-upgrade-tests
ci/prow/gke-race-condition-qa-e2e-tests 17a39ec link false /test gke-race-condition-qa-e2e-tests
ci/prow/gke-postgres-scale-tests 17a39ec link false /test gke-postgres-scale-tests
ci/prow/integration-unit-tests 17a39ec link true /test integration-unit-tests
ci/prow/style-checks 17a39ec link true /test style-checks
ci/prow/go-unit-tests-release 17a39ec link true /test go-unit-tests-release
ci/prow/stackrox_branding-push-images 17a39ec link true /test stackrox_branding-push-images
ci/prow/stackrox_branding-images 17a39ec link true /test stackrox_branding-images
ci/prow/push-images 17a39ec link true /test push-images
ci/prow/images 17a39ec link true /test images
ci/prow/local-roxctl-tests 17a39ec link false /test local-roxctl-tests
ci/prow/go-unit-tests 17a39ec link true /test go-unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vladbologa
Copy link
Contributor Author

There are some module version conflicts, I tried to fix them but without success so far.

@vladbologa
Copy link
Contributor Author

We might not be able to merge this until the repo upgrades to k8s 1.24.

The problem is with some v0 otel modules. Others are having similar issues too: open-telemetry/opentelemetry-go#2938

@SimonBaeumer
Copy link
Contributor

@porridge The helm-operator rebase does currently not work because of a transitive dependency from github.com/cloudflare/cfssl/helpers package caused by an upgrade to kubernetes client 0.24.

The upgrade of this dependency does not look very trivial to me and may require an overwrite in our go.mod.
My suggestion here would be to put the helm-operator rebase into our backlog and reverting the rebase like this:

WDYTH @porridge ?

Error:

go: finding module for package go.opentelemetry.io/otel/semconv
github.com/stackrox/rox/pkg/auth/authproviders/saml imports
	github.com/cloudflare/cfssl/helpers imports
	github.com/google/certificate-transparency-go imports
	go.etcd.io/etcd/v3 imports
	go.etcd.io/etcd/tests/v3/integration imports
	go.etcd.io/etcd/server/v3/embed imports
	go.opentelemetry.io/otel/semconv: module go.opentelemetry.io/otel@latest found (v1.9.0), but does not contain package go.opentelemetry.io/otel/semconv
github.com/stackrox/rox/pkg/auth/authproviders/saml imports
	github.com/cloudflare/cfssl/helpers imports
	github.com/google/certificate-transparency-go imports
	go.etcd.io/etcd/v3 imports
	go.etcd.io/etcd/tests/v3/integration imports
	go.etcd.io/etcd/server/v3/embed imports
	go.opentelemetry.io/otel/exporters/otlp imports
	go.opentelemetry.io/otel/sdk/metric/controller/basic imports
	go.opentelemetry.io/otel/metric/registry: module go.opentelemetry.io/otel/metric@latest found (v0.31.0), but does not contain package go.opentelemetry.io/otel/metric/registry

@porridge
Copy link
Contributor

porridge commented Sep 6, 2022

  • what was the motivation for the rebase? Just hygiene, or did something else require it?
  • by when do we need to land the pause-reconcile change?

@porridge
Copy link
Contributor

porridge commented Sep 7, 2022

@SimonBaeumer ☝️ ❓

@SimonBaeumer
Copy link
Contributor

SimonBaeumer commented Sep 7, 2022

@porridge

  • what was the motivation for the rebase? Just hygiene, or did something else require it?

Hygiene, @vladbologa noticed we are behind upstream and tried to rebase. We don't have any hard need to do a rebase on upstream immediatley.

by when do we need to land the pause-reconcile change?

No hard deadline, but at some point it eventually blocks the actual upgrade implementation in the fleetshard-sync. So in 1- 2 weeks it would be great to have it merged.

@porridge
Copy link
Contributor

porridge commented Sep 7, 2022

Thanks, I'd revert the rebase, then. I'll do it, unless you prefer to @SimonBaeumer

@SimonBaeumer
Copy link
Contributor

Thanks, I'd revert the rebase, then. I'll do it, unless you prefer to @SimonBaeumer

Please go ahead, thank you @porridge for covering this.

@vladbologa vladbologa closed this Sep 19, 2022
@vladbologa vladbologa deleted the vbologa/upgrade-helm-operator-version branch September 19, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants