Skip to content

ROX-36925: VM papercuts after guest OS search #22840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vikin91 wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −4
Draft

ROX-36925: VM papercuts after guest OS search #22840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82a3cea
ROX-36925: set Facts in unknown-OS v2 lookup test
vikin91 Sep 15, 2026
541fb46
ROX-36925: log first VMScraper index-pull schedule
vikin91 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions central/sensor/service/pipeline/virtualmachineindex/pipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,9 +925,12 @@ func TestLookupGuestOS(t *testing.T) {
},
"v2 unknown guest OS leaves scan OS empty": {
v2Enabled: true,
v2VM: &storage.VirtualMachineV2{GuestOs: pkgVM.UnknownGuestOS},
v2Found: true,
wantOS: "",
v2VM: &storage.VirtualMachineV2{
GuestOs: pkgVM.UnknownGuestOS,
Facts: map[string]string{pkgVM.GuestOSKey: pkgVM.UnknownGuestOS},
},
v2Found: true,
wantOS: "",
},
"v1 store error leaves scan OS empty": {
v1Err: errors.New("db error"),
Expand Down
6 changes: 5 additions & 1 deletion sensor/common/virtualmachine/vmscraper/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,12 +412,15 @@ func (s *VMScraper) reconcile() {
liveKeys.Add(key)
st, ok := s.vmState[key]
if !ok {
nextAt := now.Add(randOffset(newVMWindow, s.randFloat64()))
st = &vmState{
nextAttemptAt: now.Add(randOffset(newVMWindow, s.randFloat64())),
nextAttemptAt: nextAt,
vmID: vm.ID,
mappingPath: metrics.MappingPathUnspecified,
}
s.vmState[key] = st
log.Infof("VMScraper: queued %q for first index pull in %s (spread window %s)",
key, nextAt.Sub(now), newVMWindow)
} else if st.vmID != vm.ID {
// namespace/name can outlive a KubeVirt recreate; do not inherit scrape state.
st = &vmState{
Expand All @@ -426,6 +429,7 @@ func (s *VMScraper) reconcile() {
mappingPath: metrics.MappingPathUnspecified,
}
s.vmState[key] = st
log.Infof("VMScraper: re-queued %q for index pull (VM identity changed)", key)
}
}
for key := range s.vmState {
Expand Down
Loading