Skip to content

ROX-28373: Enable CISA KEV reporting by default - #22835

Merged
BradLugo merged 4 commits into
masterfrom
blugo/ROX-28373
Sep 15, 2026
Merged

ROX-28373: Enable CISA KEV reporting by default#22835
BradLugo merged 4 commits into
masterfrom
blugo/ROX-28373

Conversation

@BradLugo

@BradLugo BradLugo commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Enables the CISA KEV feature by default. Also fixes CSV column misalignment.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI should be sufficient.

@BradLugo
BradLugo requested a review from ajheflin September 14, 2026 21:23
@BradLugo
BradLugo requested a review from a team as a code owner September 14, 2026 21:24
@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 88d7da72-136c-4870-aa6c-68e4ae3943c5

📥 Commits

Reviewing files that changed from the base of the PR and between eafb876 and a516d3f.

📒 Files selected for processing (1)
  • central/reports/scheduler/v2/reportgenerator/report_gen_transaction_integration_test.go

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Known exploited vulnerability detection is now enabled by default, so vulnerability reports automatically include this information.
    • CSV reports now include whether a vulnerability is associated with a known ransomware campaign when exploited-vulnerability detection is enabled.
    • When campaign information is unavailable, the CSV report displays “Not Available” to clearly distinguish missing data from a negative result.

Walkthrough

The pull request enables KnownExploitedVulnerabilities by default. Enabled CSV reports now include the Known Ransomware Campaign value beside CISA KEV. Tests cover both feature states, nil values, dynamic column positions, and generated headers.

Changes

KEV CSV reporting

Layer / File(s) Summary
Enable KEV and extend CSV rows
pkg/features/list.go, central/reports/scheduler/v2/reportgenerator/csv_gen.go		 KnownExploitedVulnerabilities now defaults to enabled. Enabled CSV rows include Known Ransomware Campaign after CISA KEV, using a boolean string or Not Available.
Validate feature-dependent column layouts
central/reports/scheduler/v2/reportgenerator/csv_gen_test.go, central/reports/scheduler/v2/reportgenerator/report_gen_transaction_integration_test.go		 Tests cover enabled and disabled states, nil values, dynamic column positions, and headers generated by formatCol().

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: vikin91, rhybrillou, ajheflin

Merge Risk: ⚪ Minimal · up to a516d

KEV reporting is enabled by default while enabled and disabled CSV exports retain aligned headers and rows, so no current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: enabling CISA KEV reporting by default.
Description check ✅ Passed The description includes the required sections, explains both changes, records modified tests, and states that CI will provide validation. Documentation, production-readiness, and CI-inspection checkb…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch blugo/ROX-28373

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest checks

1 similar comment
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest checks

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest checks

@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit f9225de. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-312-gf9225dee61

@BradLugo
BradLugo requested a review from a team as a code owner September 15, 2026 18:08
@BradLugo

BradLugo commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Enabling auto-merge

@BradLugo
BradLugo enabled auto-merge (squash) September 15, 2026 19:04
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.80%. Comparing base (116d16d) to head (a516d3f).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #22835      +/-   ##
==========================================
- Coverage   51.82%   51.80%   -0.03%     
==========================================
  Files        2901     2901              
  Lines      182815   182853      +38     
==========================================
- Hits        94753    94721      -32     
- Misses      79774    79818      +44     
- Partials     8288     8314      +26
Flag Coverage Δ
go-unit-tests 51.80% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown

@BradLugo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests a516d3f link false /test gke-qa-e2e-tests
ci/prow/gke-operator-e2e-tests a516d3f link false /test gke-operator-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BradLugo
BradLugo merged commit f9225de into master Sep 15, 2026
102 of 113 checks passed
@BradLugo
BradLugo deleted the blugo/ROX-28373 branch September 15, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajheflin ajheflin ajheflin approved these changes

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BradLugo @ajheflin