Skip to content

ROX-36975: Fix race #22827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtodor merged 1 commit into from
Sep 15, 2026
+3 −9
Merged

ROX-36975: Fix race #22827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions pkg/queue/queue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,16 +430,10 @@ func testEmptyPullAfterSignal(t *testing.T, consumerName string, startConsumer f
<-consumerStarted
synctest.Wait()

Comment thread
mtodor marked this conversation as resolved.
q.Push(99)
pulled := q.Pull()
assert.Equal(t, 99, pulled)

// Simulate waking after another consumer has already taken the item.
// Using Push followed by Pull would race with the waiting consumer.
q.notEmptySignal.Signal()
synctest.Wait()
select {
case <-itemReceived:
t.Fatalf("%s should not have received the pulled item", consumerName)
default:
}

q.Push(42)
synctest.Wait()
Expand Down
Loading