Skip to content

chore: Remove scripts/offline-bundle - #22826

Open
msugakov wants to merge 1 commit into
masterfrom
misha/remove-offline-bundle
Open

chore: Remove scripts/offline-bundle#22826
msugakov wants to merge 1 commit into
masterfrom
misha/remove-offline-bundle

Conversation

@msugakov

@msugakov msugakov commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Nothing seems to use it since the removal in 588093f#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47L4107

Discovered as part of #22822

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

Checked Git history:

$ git log -G 'make .*offline-bundle'   
commit 588093f91d9cd48c188000ae14e7862ac09b88a3
Author: Gavin Jefferies <gavin@stackrox.com>
Date:   Mon Jun 27 09:27:13 2022 -0700

    OSCI: Onboard push-release (#2207)

commit 024065744a970b43eeb965c77a0b5ef8caa67917
Author: Josh Komoroske <josh@stackrox.com>
Date:   Thu Aug 22 17:09:51 2019 -0700

    ROX-2128 - Script for creating offline installation bundles (stackrox/rox#3148)

$ git log -G 'offline-bundle/create.sh'
commit c173f8bbef27851edf422072d01f1c49f9f2d4b5
Author: Marcin Owsiany <porridge@redhat.com>
Date:   Thu Jun 23 16:35:36 2022 +0200

    Optionally unsilence some make commands. (#2171)
    
    This is useful when debugging makefile issues.

commit 024065744a970b43eeb965c77a0b5ef8caa67917
Author: Josh Komoroske <josh@stackrox.com>
Date:   Thu Aug 22 17:09:51 2019 -0700

    ROX-2128 - Script for creating offline installation bundles (stackrox/rox#3148)

Searching for offline-bundle in the current repo brings up only https://github.com/stackrox/stackrox/blob/master/.github/workflows/scanner-offline-bundle-update.yaml but that seems to be a V4 thing.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b5637c4b-5f59-480b-9be6-bfc46152f527

📥 Commits

Reviewing files that changed from the base of the PR and between 241cf27 and 27bf3bc.

📒 Files selected for processing (7)
  • Makefile
  • scripts/offline-bundle/.gitignore
  • scripts/offline-bundle/create.sh
  • scripts/offline-bundle/image-bundle/README.txt
  • scripts/offline-bundle/image-bundle/import.sh
  • scripts/offline-bundle/image-collector-bundle/README.txt
  • scripts/offline-bundle/image-collector-bundle/import.sh
💤 Files with no reviewable changes (7)
  • scripts/offline-bundle/image-collector-bundle/import.sh
  • scripts/offline-bundle/image-bundle/README.txt
  • scripts/offline-bundle/image-collector-bundle/README.txt
  • Makefile
  • scripts/offline-bundle/create.sh
  • scripts/offline-bundle/.gitignore
  • scripts/offline-bundle/image-bundle/import.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Removed Features
    • Removed support for creating offline bundles.
    • Removed offline image-bundle and Collector image-bundle import workflows.
    • Removed related offline bundle documentation and setup guidance.

Walkthrough

The offline bundle workflow was removed. This includes Make targets, bundle creation, image import scripts, Collector import scripts, ignore rules, and related documentation.

Changes

Offline bundle removal

Layer / File(s) Summary
Remove bundle generation
Makefile, scripts/offline-bundle/create.sh, scripts/offline-bundle/.gitignore		 The offline bundle Make targets, creation script, and generated-file ignore rules were removed.
Remove bundle import workflow
scripts/offline-bundle/image-bundle/*, scripts/offline-bundle/image-collector-bundle/*		 The image and Collector import scripts and their README files were removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 27bf3

The removed offline-bundle workflow has no remaining in-repository dependencies, so no concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: removal of the scripts/offline-bundle directory.
Description check ✅ Passed The description includes all required sections, explains the removal, records documentation decisions, states that no automated testing was needed, and provides validation details. The CI inspection c…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch misha/remove-offline-bundle

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.78%. Comparing base (241cf27) to head (27bf3bc).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #22826      +/-   ##
==========================================
- Coverage   51.82%   51.78%   -0.05%     
==========================================
  Files        2901     2901              
  Lines      182807   182807              
==========================================
- Hits        94737    94663      -74     
- Misses      79779    79834      +55     
- Partials     8291     8310      +19
Flag Coverage Δ
go-unit-tests 51.78% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 27bf3bc. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-295-g27bf3bc2c3

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

@msugakov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 27bf3bc link false /test ocp-4-12-qa-e2e-tests
ci/prow/gke-nongroovy-e2e-tests 27bf3bc link true /test gke-nongroovy-e2e-tests
ci/prow/gke-ui-e2e-tests 27bf3bc link true /test gke-ui-e2e-tests
ci/prow/gke-operator-e2e-tests 27bf3bc link false /test gke-operator-e2e-tests
ci/prow/gke-qa-e2e-tests 27bf3bc link false /test gke-qa-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests 27bf3bc link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-22-nongroovy-e2e-tests 27bf3bc link false /test ocp-4-22-nongroovy-e2e-tests
ci/prow/ocp-4-22-operator-e2e-tests 27bf3bc link false /test ocp-4-22-operator-e2e-tests
ci/prow/ocp-4-22-qa-e2e-tests 27bf3bc link false /test ocp-4-22-qa-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 27bf3bc link false /test ocp-4-12-operator-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@msugakov