Skip to content

refactor: convert 5 more workers to PeriodicWorker - #22821

Draft
ebensh wants to merge 1 commit into
worker-archetypes-foundationfrom
worker-archetypes-batch-2
Draft

ebensh wants to merge 1 commit into
worker-archetypes-foundationfrom
worker-archetypes-batch-2

Conversation

@ebensh

@ebensh ebensh commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Description

Converts 5 more background workers to use the PeriodicWorker archetype:

  • central/administration/events/handler/handler.go — "admin-events-flush" (preserves final flush on Stop)
  • central/scannerdefinitions/handler/handler.go — "scanner-defs-cleanup" (gains proper shutdown)
  • central/processindicator/datastore/datastore_impl.go — "process-indicator-pruner"
  • central/sensor/telemetry/controller_impl.go — "telemetry-channel-gc"
  • central/declarativeconfig/manager_impl.go — "declarative-config-reconciler" (Signal replaced with buffered channel for ShortCircuit)

Depends on #22823 (foundation).

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

  • go build ./central/... passes
  • Each converted worker preserves original behavior

🤖 Generated with Claude Code

https://claude.ai/code/session_01W7RzcPcJyXMZUqeSXfqTZQ

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit dffeb94. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-198-gdffeb94cd4

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.59%. Comparing base (44a57aa) to head (dffeb94).

Files with missing lines Patch % Lines
central/declarativeconfig/manager_impl.go 23.07% 10 Missing ⚠️
central/scannerdefinitions/handler/handler.go 46.66% 5 Missing and 3 partials ⚠️
central/administration/events/handler/handler.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           worker-archetypes-foundation   #22821      +/-   ##
================================================================
- Coverage                         51.83%   51.59%   -0.25%     
================================================================
  Files                              2906     2892      -14     
  Lines                            182990   181830    -1160     
================================================================
- Hits                              94858    93817    -1041     
+ Misses                            79822    79810      -12     
+ Partials                           8310     8203     -107     
Flag Coverage Δ
go-unit-tests 51.59% <63.63%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ebensh
ebensh force-pushed the worker-archetypes-prototype branch from c26de20 to 3af934e Compare September 14, 2026 12:03
@ebensh
ebensh force-pushed the worker-archetypes-batch-2 branch from 84e1480 to fddee26 Compare September 14, 2026 12:03
@ebensh ebensh changed the title feat: convert 5 more workers to PeriodicWorker refactor: convert 5 more workers to PeriodicWorker Sep 14, 2026
@ebensh
ebensh changed the base branch from worker-archetypes-prototype to worker-archetypes-foundation September 14, 2026 12:04
Convert admin-events flush, scanner-defs cleanup, process-indicator pruner,
telemetry channel GC, and declarative-config reconciler.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W7RzcPcJyXMZUqeSXfqTZQ
@ebensh
ebensh force-pushed the worker-archetypes-batch-2 branch from fddee26 to dffeb94 Compare September 15, 2026 13:54
@ebensh
ebensh force-pushed the worker-archetypes-foundation branch from 72e18f8 to 44a57aa Compare September 15, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant