Skip to content

ROX-36944: Upgrade test reduced to versions +/= 3 - #22791

Draft
dashrews78 wants to merge 2 commits into
masterfrom
dashrews/upgrade-start-4.10-36944
Draft

ROX-36944: Upgrade test reduced to versions +/= 3#22791
dashrews78 wants to merge 2 commits into
masterfrom
dashrews/upgrade-start-4.10-36944

Conversation

@dashrews78

@dashrews78 dashrews78 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@dashrews78

dashrews78 commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d64022c4-a538-4465-bffd-a3e63f0b3d0f

📥 Commits

Reviewing files that changed from the base of the PR and between 89f8690 and c53d5bd.

📒 Files selected for processing (1)
  • tests/upgrade/postgres_run.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated PostgreSQL end-to-end and upgrade coverage to use the 4.10.7 release baseline.
    • Streamlined upgrade scenarios to retain 4.11.3 as the intermediate release.
    • Standardized backup restoration across PostgreSQL test workflows.
    • Updated rollback testing to target the 4.10.7 release.
    • Improved upgrade validation while Central starts and confirmed readiness for Central, the database, and Scanner V4.
    • Removed obsolete legacy scanner validation from end-to-end test workflows.

Walkthrough

The end-to-end and upgrade tests now use generic PostgreSQL restore helpers and a PostgreSQL 4.10 fixture. Upgrade scenarios use updated 4.10 releases. Central upgrade support adds Helm orchestration and readiness handling.

Changes

PostgreSQL upgrade test updates

Layer / File(s) Summary
Generic PostgreSQL restore flow
tests/e2e/lib.sh, tests/e2e/run.sh, tests/upgrade/lib.sh, tests/upgrade/postgres_run.sh, tests/upgrade/postgres_upgrade_run.sh		 Restore helpers use generic names. The restored fixture changes from PostgreSQL 4.6 to PostgreSQL 4.10.
Release and rollback path updates
tests/upgrade/postgres_run.sh, tests/upgrade/postgres_upgrade_run.sh		 Upgrade scenarios use updated release commits, 4.10.7 rollback targets, and the 4.10.7 to 4.11.3 sequence.
Central Helm upgrade orchestration
tests/upgrade/lib.sh		 Deployment-count polling accepts empty or null GraphQL results. Helm orchestration configures Scanner V4 and waits for Central, the database, and Scanner V4 readiness.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant UpgradeTest
  participant Helm
  participant Central
  participant ScannerV4
  UpgradeTest->>Helm: upgrade_central_helm_to_head
  Helm->>Central: apply upgrade configuration
  Central-->>Helm: report API and database readiness
  Helm->>ScannerV4: enable Scanner V4
  ScannerV4-->>Helm: report vulnerability readiness
  Helm-->>UpgradeTest: complete upgrade
Loading

Suggested reviewers: ajheflin

Merge Risk: ⚪ Minimal · up to 571dc

The upgrade test changes update the intended release sequence without establishing a current failure, so the PR is mergeable subject to normal validation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description retains placeholder text such as "change me!" and provides no implementation details or validation results. The checklist is also incomplete. Replace the placeholder text with a summary of the upgrade-test changes, state the documentation decision, complete the testing and quality checklist, and describe the validation performed or explain why testing was skipped.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the upgrade-test reduction and matches the main changes from versions 4.10.0 through 4.10.7.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dashrews/upgrade-start-4.10-36944

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.79%. Comparing base (4ce5f0f) to head (571dc0f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #22791      +/-   ##
==========================================
- Coverage   51.82%   51.79%   -0.04%     
==========================================
  Files        2901     2901              
  Lines      182819   182819              
==========================================
- Hits        94755    94691      -64     
- Misses      79777    79822      +45     
- Partials     8287     8306      +19
Flag Coverage Δ
go-unit-tests 51.79% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 571dc0f. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-302-g571dc0f445

@dashrews78 dashrews78 added the e2e-gke-upgrade-tests Triggers GHA-based gke-upgrade-tests on draft PRs label Sep 10, 2026
@dashrews78
dashrews78 force-pushed the dashrews/upgrade-start-4.10-36944 branch from c7286b1 to 89f8690 Compare September 14, 2026 18:15
This was referenced Sep 14, 2026
Draft
Draft
Draft
Draft
@dashrews78
dashrews78 force-pushed the dashrews/upgrade-start-4.10-36944 branch from c53d5bd to 571dc0f Compare September 15, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress e2e-gke-upgrade-tests Triggers GHA-based gke-upgrade-tests on draft PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dashrews78